AllSpiceMirrors/kicad
7
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-21 00:21:25 +00:00
Files Issues Releases Activity

Raytracing: use all lights in preview mode.

Browse Source 
It's not significantly slower, but looks much better.

Related: https://gitlab.com/kicad/code/kicad/-/issues/17354
This commit is contained in:
Alex Shvartzkop 2025-01-19 23:51:58 +03:00
parent 6b3396ea2d
commit 0118d7fb38
1 changed files with 0 additions and 7 deletions

7
3d-viewer/3d_rendering/raytracing/render_3d_raytrace_base.cpp
View File

@ -1443,9 +1443,6 @@ SFVEC4F RENDER_3D_RAYTRACE_BASE::shadeHit( const SFVEC4F& aBgColor, const RAY& a
light->GetLightParameters( hitPoint, vectorToLight, colorOfLight, distToLight );
if( m_isPreview )
colorOfLight = SFVEC3F( 1.0f );
const float NdotL = glm::dot( aHitInfo.m_HitNormal, vectorToLight );
// Only calc shade if the normal is facing the direction of light,
@ -1514,10 +1511,6 @@ SFVEC4F RENDER_3D_RAYTRACE_BASE::shadeHit( const SFVEC4F& aBgColor, const RAY& a
shadow_att_factor_light ),
1.0 );
}
// Only use the headlight (or whatever the first light is) for preview
if( m_isPreview )
break;
}
// Improvement: this is not taking in account the lightcolor