AllSpiceMirrors/kicad
7
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-21 19:33:44 +00:00
Files Issues Releases Activity

Git: safety for calling KIGIT_COMMON with no repo

Browse Source
This commit is contained in:
Jon Evans 2025-02-08 16:32:28 -05:00
parent d4815534bf
commit 04387dd42f
1 changed files with 8 additions and 0 deletions

8
common/git/kicad_git_common.cpp
View File

@ -48,6 +48,7 @@ git_repository* KIGIT_COMMON::GetRepo() const
wxString KIGIT_COMMON::GetCurrentBranchName() const
{
wxCHECK( m_repo, wxEmptyString );
git_reference* head = nullptr;
int retval = git_repository_head( &head, m_repo );
@ -80,6 +81,7 @@ wxString KIGIT_COMMON::GetCurrentBranchName() const
std::vector<wxString> KIGIT_COMMON::GetBranchNames() const
{
wxCHECK( m_repo, {} );
std::vector<wxString> branchNames;
std::map<git_time_t, wxString> branchNamesMap;
wxString firstName;
@ -133,6 +135,7 @@ std::vector<wxString> KIGIT_COMMON::GetBranchNames() const
std::vector<wxString> KIGIT_COMMON::GetProjectDirs()
{
wxCHECK( m_repo, {} );
std::vector<wxString> projDirs;
git_oid oid;
@ -366,6 +369,7 @@ bool KIGIT_COMMON::HasLocalCommits() const
bool KIGIT_COMMON::HasPushAndPullRemote() const
{
wxCHECK( m_repo, false );
git_remote* remote = nullptr;
if( git_remote_lookup( &remote, m_repo, "origin" ) != GIT_OK )
@ -393,6 +397,8 @@ bool KIGIT_COMMON::HasPushAndPullRemote() const
wxString KIGIT_COMMON::GetRemotename() const
{
wxCHECK( m_repo, wxEmptyString );
wxString retval;
git_reference* head = nullptr;
git_reference* upstream = nullptr;
@ -500,6 +506,8 @@ void KIGIT_COMMON::updatePublicKeys()
void KIGIT_COMMON::UpdateCurrentBranchInfo()
{
wxCHECK( m_repo, /* void */ );
// We want to get the current branch's upstream url as well as the stored password
// if one exists given the url and username.