AllSpiceMirrors/kicad
7
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-04 23:05:30 +00:00
Files Issues Releases Activity

Include child SCH_PINs in SCH_RULE_AREA item caches

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20332
This commit is contained in:
JamesJCode 2025-03-14 20:55:44 +00:00
parent 10237c4270
commit 078a01976f
1 changed files with 9 additions and 6 deletions

15
eeschema/sch_rule_area.cpp
View File

@ -227,9 +227,7 @@ void SCH_RULE_AREA::RefreshContainedItemsAndDirectives(
assert( labelConnectionPoints.size() == 1 );
if( GetPolyShape().CollideEdge( labelConnectionPoints[0], nullptr, 5 ) )
{
addDirective( label, view );
}
}
// If directives have changed, we need to force an update of the contained items connectivity
@ -248,9 +246,7 @@ void SCH_RULE_AREA::RefreshContainedItemsAndDirectives(
lineItem->GetLineWidth() );
if( GetPolyShape().Collide( &lineSeg ) )
{
addContainedItem( areaItem );
}
}
else if( areaItem->IsType(
{ SCH_PIN_T, SCH_LABEL_T, SCH_GLOBAL_LABEL_T, SCH_HIER_LABEL_T } ) )
@ -259,13 +255,20 @@ void SCH_RULE_AREA::RefreshContainedItemsAndDirectives(
assert( connectionPoints.size() == 1 );
if( GetPolyShape().Collide( connectionPoints[0] ) )
{
addContainedItem( areaItem );
}
}
else if( areaItem->IsType( { SCH_SYMBOL_T } ) )
{
addContainedItem( areaItem );
// Add child pins which are within the rule area
const SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( areaItem );
for( SCH_PIN* pin : symbol->GetPins() )
{
if( GetPolyShape().Collide( pin->GetPosition() ) )
addContainedItem( pin );
}
}
}
}