7
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-21 00:21:25 +00:00

Improve netlist import messages for component class changes

Fixes https://gitlab.com/kicad/code/kicad/-/issues/18917
This commit is contained in:
JamesJCode 2024-10-15 14:05:12 +01:00
parent 119eea38c3
commit 1fcc71a5c7

View File

@ -231,16 +231,43 @@ void BOARD_NETLIST_UPDATER::updateComponentClass( FOOTPRINT* aFootprint, COMPONE
if( m_isDryRun )
{
msg.Printf( _( "Change %s component class from %s to %s." ), aFootprint->GetReference(),
curClassName, newClassName );
if( curClassName == wxEmptyString && newClassName != wxEmptyString )
{
msg.Printf( _( "Change %s component class to %s." ), aFootprint->GetReference(),
newClassName );
}
else if( curClassName != wxEmptyString && newClassName == wxEmptyString )
{
msg.Printf( _( "Remove %s component class (currently %s)." ),
aFootprint->GetReference(), curClassName );
}
else
{
msg.Printf( _( "Change %s component class from %s to %s." ), aFootprint->GetReference(),
curClassName, newClassName );
}
}
else
{
wxASSERT_MSG( newClass != nullptr, "Component class should not be nullptr" );
aFootprint->SetComponentClass( newClass );
msg.Printf( _( "Changed %s component class from %s to %s." ), aFootprint->GetReference(),
curClassName, newClassName );
if( curClassName == wxEmptyString && newClassName != wxEmptyString )
{
msg.Printf( _( "Changed %s component class to %s." ), aFootprint->GetReference(),
newClassName );
}
else if( curClassName != wxEmptyString && newClassName == wxEmptyString )
{
msg.Printf( _( "Removed %s component class (was %s)." ), aFootprint->GetReference(),
curClassName );
}
else
{
msg.Printf( _( "Changed %s component class from %s to %s." ),
aFootprint->GetReference(), curClassName, newClassName );
}
}
m_reporter->Report( msg, RPT_SEVERITY_ACTION );