AllSpiceMirrors/kicad
7
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-18 19:39:17 +00:00
Files Issues Releases Activity

Do not call Select on an empty combobox

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19594
This commit is contained in:
Jon Evans 2025-01-11 08:25:04 -05:00
parent 42a1d1cf0b
commit 2f96dfd5cb
1 changed files with 4 additions and 2 deletions

6
pcbnew/dialogs/dialog_rule_area_properties.cpp
View File

@ -256,7 +256,8 @@ bool DIALOG_RULE_AREA_PROPERTIES::TransferDataToWindow()
for( const wxString& sourceName : classNames )
m_placementProperties->m_componentClassCombo->Append( sourceName );
m_placementProperties->m_componentClassCombo->Select( 0 );
if( !classNames.empty() )
m_placementProperties->m_componentClassCombo->Select( 0 );
// Fetch sheet names
std::set<wxString> sheetNames;
@ -267,7 +268,8 @@ bool DIALOG_RULE_AREA_PROPERTIES::TransferDataToWindow()
for( const wxString& sourceName : sheetNames )
m_placementProperties->m_sheetCombo->Append( sourceName );
m_placementProperties->m_sheetCombo->Select( 0 );
if( !sheetNames.empty() )
m_placementProperties->m_sheetCombo->Select( 0 );
}
auto setupCurrentSourceSelection = [&]( wxComboBox* cb )