AllSpiceMirrors/kicad
7
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-07 21:25:31 +00:00
Files Issues Releases Activity

Separate immediate and delayed action dispatch

Browse Source 
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
This commit is contained in:
Ian McInerney 2023-06-26 23:16:51 +01:00
parent a318c57d77
commit 2fb6f19a84
102 changed files with 526 additions and 479 deletions
3d-viewer/3d_navlib
nl_3d_viewer_plugin_impl.cpp
common
dialog_about
dialog_about.cpp
dialogs
dialog_grid_settings.cpp
eda_base_frame.cppeda_draw_frame.cpp
tool
action_manager.cppaction_menu.cppcommon_tools.cpp
cvpcb
cvpcb_mainframe.cppdisplay_footprints_frame.cppfootprints_listbox.cpp
tools
cvpcb_association_tool.cppcvpcb_control.cppcvpcb_fpviewer_selection_tool.cpp
eeschema
cross-probing.cpp
dialogs
dialog_erc.cppdialog_migrate_buses.cpp
files-io.cpp
navlib
nl_schematic_plugin_impl.cpp
picksymbol.cppsch_edit_frame.cppschematic_undo_redo.cpp
sim
simulator_frame.cpp
symbol_editor
symbol_edit_frame.cppsymbol_editor.cppsymbol_editor_undo_redo.cpp
symbol_viewer_frame.cpp
tools
ee_selection_tool.cppsch_drawing_tools.cppsch_edit_tool.cppsch_editor_control.cppsch_line_wire_bus_tool.cppsch_move_tool.cppsch_navigate_tool.cppsimulator_control.cppsymbol_editor_control.cppsymbol_editor_drawing_tools.cppsymbol_editor_edit_tool.cppsymbol_editor_move_tool.cpp
widgets
hierarchy_pane.cppsearch_handlers.cppsymbol_tree_pane.cpp
gerbview
dialogs
dialog_print_gerbview.cpp
files.cppgerbview_frame.cpp
tools
gerbview_control.cppgerbview_selection_tool.cpp
widgets
gerbview_layer_widget.cpp
include/tool
tool_manager.h
kicad
kicad_manager_frame.cppproject_tree_item.cpp
pagelayout_editor
pl_editor_frame.cpppl_editor_undo_redo.cpp
tools
pl_drawing_tools.cpppl_edit_tool.cpppl_selection_tool.cpp
pcbnew
array_creator.cppboard_commit.cppcross-probing.cpp
dialogs
dialog_cleanup_graphics.cppdialog_cleanup_tracks_and_vias.cppdialog_drc.cppdialog_find.cppdialog_footprint_checker.cppdialog_global_deletion.cppdialog_group_properties.cppdialog_import_netlist.cppdialog_position_relative.cppdialog_print_pcbnew.cppdialog_update_pcb.cpp
edit.cppedit_track_width.cppfiles.cppfootprint_edit_frame.cppfootprint_editor_utils.cppfootprint_libraries_utils.cppfootprint_viewer_frame.cppfootprint_wizard_frame.cpp
microwave
microwave_inductor.cpp
navlib
nl_pcbnew_plugin_impl.cpp
netlist_reader
netlist.cpp
pcb_edit_frame.cpp
router
length_tuner_tool.cpprouter_tool.cpp
tools
board_editor_control.cppboard_inspection_tool.cppdrawing_stackup_table_tool.cppdrawing_tool.cppdrc_tool.cppedit_tool.cppedit_tool_move_fct.cppfootprint_editor_control.cppgroup_tool.cpppad_tool.cpppcb_control.cpppcb_point_editor.cpppcb_selection_tool.cpppcb_tool_base.cppposition_relative_tool.cppzone_create_helper.cpp
widgets
appearance_controls.cppsearch_handlers.cpp

2
3d-viewer/3d_navlib/nl_3d_viewer_plugin_impl.cpp
View File

@ -591,7 +591,7 @@ long NL_3D_VIEWER_PLUGIN_IMPL::SetActiveCommand( std::string commandId )
if( runAction )
{
tool_manager->RunAction( *context, true );
tool_manager->RunAction( *context );
m_canvas->Request_refresh();
}
}

4
common/dialog_about/dialog_about.cpp
View File

@ -478,14 +478,14 @@ void DIALOG_ABOUT::onCopyVersionInfo( wxCommandEvent& event )
void DIALOG_ABOUT::onDonateClick( wxCommandEvent& event )
{
if( TOOL_MANAGER* mgr = static_cast<EDA_BASE_FRAME*>( GetParent() )->GetToolManager() )
mgr->RunAction( "common.SuiteControl.donate", true );
mgr->RunAction( "common.SuiteControl.donate" );
}
void DIALOG_ABOUT::onReportBug( wxCommandEvent& event )
{
if( TOOL_MANAGER* mgr = static_cast<EDA_BASE_FRAME*>( GetParent() )->GetToolManager() )
mgr->RunAction( "common.SuiteControl.reportBug", true );
mgr->RunAction( "common.SuiteControl.reportBug" );
}

4
common/dialogs/dialog_grid_settings.cpp
View File

@ -130,8 +130,8 @@ bool DIALOG_GRID_SETTINGS::TransferDataFromWindow()
mgr->ResetTools( TOOL_BASE::REDRAW );
// Notify GAL
mgr->RunAction( ACTIONS::gridPreset, true, gridCfg.last_size_idx );
mgr->RunAction( ACTIONS::gridSetOrigin, true, new VECTOR2D( m_parent->GetGridOrigin() ) );
mgr->RunAction( ACTIONS::gridPreset, gridCfg.last_size_idx );
mgr->RunAction( ACTIONS::gridSetOrigin, new VECTOR2D( m_parent->GetGridOrigin() ) );
m_parent->UpdateGridSelectBox();

2
common/eda_base_frame.cpp
View File

@ -1260,7 +1260,7 @@ void EDA_BASE_FRAME::DoWithAcceptedFiles()
for( const wxFileName& file : m_AcceptedFiles )
{
wxString fn = file.GetFullPath();
m_toolManager->RunAction<wxString*>( *m_acceptedExts.at( file.GetExt() ), true, &fn );
m_toolManager->RunAction<wxString*>( *m_acceptedExts.at( file.GetExt() ), &fn );
}
}

12
common/eda_draw_frame.cpp
View File

@ -276,7 +276,7 @@ void EDA_DRAW_FRAME::unitsChangeRefresh()
{
// Notify all tools the units have changed
if( m_toolManager )
m_toolManager->RunAction( ACTIONS::updateUnits, true );
m_toolManager->RunAction( ACTIONS::updateUnits );
UpdateStatusBar();
UpdateMsgPanel();
@ -347,7 +347,7 @@ void EDA_DRAW_FRAME::CommonSettingsChanged( bool aEnvVarsChanged, bool aTextVars
// Notify all tools the preferences have changed
if( m_toolManager )
m_toolManager->RunAction( ACTIONS::updatePreferences, true );
m_toolManager->RunAction( ACTIONS::updatePreferences );
}
@ -465,11 +465,11 @@ void EDA_DRAW_FRAME::OnSelectGrid( wxCommandEvent& event )
// (Only matters on some versions of GTK.)
wxSafeYield();
m_toolManager->RunAction( ACTIONS::gridProperties, true );
m_toolManager->RunAction( ACTIONS::gridProperties );
}
else
{
m_toolManager->RunAction( ACTIONS::gridPreset, true, idx );
m_toolManager->RunAction( ACTIONS::gridPreset, idx );
}
UpdateStatusBar();
@ -556,7 +556,7 @@ void EDA_DRAW_FRAME::OnSelectZoom( wxCommandEvent& event )
if( id < 0 || !( id < (int)m_zoomSelectBox->GetCount() ) )
return;
m_toolManager->RunAction( ACTIONS::zoomPreset, true, id );
m_toolManager->RunAction( ACTIONS::zoomPreset, id );
UpdateStatusBar();
m_canvas->Refresh();
// Needed on Windows because clicking on m_zoomSelectBox remove the focus from m_canvas
@ -913,7 +913,7 @@ void EDA_DRAW_FRAME::HardRedraw()
void EDA_DRAW_FRAME::Zoom_Automatique( bool aWarpPointer )
{
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
}

4
common/tool/action_manager.cpp
View File

@ -205,7 +205,7 @@ bool ACTION_MANAGER::RunHotKey( int aHotKey ) const
KeyNameFromKeyCode( aHotKey ) );
if( runAction )
return m_toolMgr->RunAction( *context, true );
return m_toolMgr->RunAction( *context );
}
else if( !global.empty() )
{
@ -222,7 +222,7 @@ bool ACTION_MANAGER::RunHotKey( int aHotKey ) const
act->GetName(),
KeyNameFromKeyCode( aHotKey ) );
if( runAction && m_toolMgr->RunAction( *act, true ) )
if( runAction && m_toolMgr->RunAction( *act ) )
return true;
}
}

2
common/tool/action_menu.cpp
View File

@ -405,7 +405,7 @@ void ACTION_MENU::OnMenuEvent( wxMenuEvent& aEvent )
if( type == wxEVT_MENU_OPEN )
{
if( m_dirty && m_tool )
getToolManager()->RunAction<ACTION_MENU*>( ACTIONS::updateMenu, true, this );
getToolManager()->RunAction<ACTION_MENU*>( ACTIONS::updateMenu, this );
wxMenu* parent = dynamic_cast<wxMenu*>( GetParent() );

2
common/tool/common_tools.cpp
View File

@ -163,7 +163,7 @@ int COMMON_TOOLS::CursorControl( const TOOL_EVENT& aEvent )
}
getViewControls()->SetCursorPosition( cursor, true, true, type );
m_toolMgr->RunAction( ACTIONS::refreshPreview );
m_toolMgr->PostAction( ACTIONS::refreshPreview );
return 0;
}

6
cvpcb/cvpcb_mainframe.cpp
View File

@ -328,7 +328,7 @@ void CVPCB_MAINFRAME::setupEventHandlers()
[this]( wxCommandEvent& )
{
// saveAssociations must be run immediately
GetToolManager()->RunAction( CVPCB_ACTIONS::saveAssociationsToFile, true );
GetToolManager()->RunAction( CVPCB_ACTIONS::saveAssociationsToFile );
} );
// Connect the handlers for the ok/cancel buttons
@ -336,7 +336,7 @@ void CVPCB_MAINFRAME::setupEventHandlers()
[this]( wxCommandEvent& )
{
// saveAssociations must be run immediately, before running Close( true )
GetToolManager()->RunAction( CVPCB_ACTIONS::saveAssociationsToSchematic, true );
GetToolManager()->RunAction( CVPCB_ACTIONS::saveAssociationsToSchematic );
Close( true );
}, wxID_OK );
Bind( wxEVT_BUTTON,
@ -503,7 +503,7 @@ void CVPCB_MAINFRAME::updateFootprintViewerOnIdle( wxIdleEvent& aEvent )
// If the footprint view window is displayed, update the footprint.
if( GetFootprintViewerFrame() )
GetToolManager()->RunAction( CVPCB_ACTIONS::showFootprintViewer, true );
GetToolManager()->RunAction( CVPCB_ACTIONS::showFootprintViewer );
DisplayStatus();

4
cvpcb/display_footprints_frame.cpp
View File

@ -572,9 +572,9 @@ void DISPLAY_FOOTPRINTS_FRAME::updateView()
wxAuiToolBarItem* toolOpt = m_mainToolBar->FindTool( ID_CVPCB_FPVIEWER_AUTOZOOM_TOOL );
if( toolOpt->GetState() & wxAUI_BUTTON_STATE_CHECKED )
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
else
m_toolManager->RunAction( ACTIONS::centerContents, true );
m_toolManager->RunAction( ACTIONS::centerContents );
UpdateMsgPanel();
}

2
cvpcb/footprints_listbox.cpp
View File

@ -205,7 +205,7 @@ void FOOTPRINTS_LISTBOX::OnLeftClick( wxListEvent& event )
void FOOTPRINTS_LISTBOX::OnLeftDClick( wxListEvent& event )
{
GetParent()->GetToolManager()->RunAction( CVPCB_ACTIONS::associate, true );
GetParent()->GetToolManager()->RunAction( CVPCB_ACTIONS::associate );
}

2
cvpcb/tools/cvpcb_association_tool.cpp
View File

@ -221,7 +221,7 @@ int CVPCB_ASSOCIATION_TOOL::Associate( const TOOL_EVENT& aEvent )
}
// Move to the next not associated component
m_toolMgr->RunAction( CVPCB_ACTIONS::gotoNextNA );
m_toolMgr->PostAction( CVPCB_ACTIONS::gotoNextNA );
return 0;
}

4
cvpcb/tools/cvpcb_control.cpp
View File

@ -70,13 +70,13 @@ int CVPCB_CONTROL::Main( const TOOL_EVENT& aEvent )
{
// The right arrow moves focus to the focusable object to the right
case WXK_RIGHT:
m_toolMgr->RunAction( CVPCB_ACTIONS::changeFocusRight );
m_toolMgr->PostAction( CVPCB_ACTIONS::changeFocusRight );
handled = true;
break;
// The left arrow moves focus to the focusable object to the left
case WXK_LEFT:
m_toolMgr->RunAction( CVPCB_ACTIONS::changeFocusLeft );
m_toolMgr->PostAction( CVPCB_ACTIONS::changeFocusLeft );
handled = true;
break;

2
cvpcb/tools/cvpcb_fpviewer_selection_tool.cpp
View File

@ -64,7 +64,7 @@ int CVPCB_FOOTPRINT_VIEWER_SELECTION_TOOL::Main( const TOOL_EVENT& aEvent )
}
else if( evt->IsDblClick( BUT_MIDDLE ) )
{
m_toolMgr->RunAction( ACTIONS::zoomFitScreen, true );
m_toolMgr->RunAction( ACTIONS::zoomFitScreen );
}
else if( evt->IsCancel() || evt->Action() == TA_UNDO_REDO_PRE )
{

8
eeschema/cross-probing.cpp
View File

@ -215,12 +215,12 @@ void SCH_EDIT_FRAME::ExecuteRemoteCommand( const char* cmdline )
if( strcmp( idcmd, "$CONFIG" ) == 0 )
{
GetToolManager()->RunAction( ACTIONS::showSymbolLibTable, true );
GetToolManager()->RunAction( ACTIONS::showSymbolLibTable );
return;
}
else if( strcmp( idcmd, "$ERC" ) == 0 )
{
GetToolManager()->RunAction( EE_ACTIONS::runERC, true );
GetToolManager()->RunAction( EE_ACTIONS::runERC );
return;
}
else if( strcmp( idcmd, "$NET:" ) == 0 )
@ -235,7 +235,7 @@ void SCH_EDIT_FRAME::ExecuteRemoteCommand( const char* cmdline )
else
m_highlightedConn = wxEmptyString;
GetToolManager()->RunAction( EE_ACTIONS::updateNetHighlighting, true );
GetToolManager()->RunAction( EE_ACTIONS::updateNetHighlighting );
SetStatusText( _( "Selected net:" ) + wxS( " " ) + UnescapeString( netName ) );
return;
@ -970,7 +970,7 @@ void SCH_EDIT_FRAME::KiwayMailIn( KIWAY_EXPRESS& mail )
break;
case MAIL_SCH_UPDATE:
m_toolManager->RunAction( ACTIONS::updateSchematicFromPcb, true );
m_toolManager->RunAction( ACTIONS::updateSchematicFromPcb );
break;
case MAIL_RELOAD_LIB:

8
eeschema/dialogs/dialog_erc.cpp
View File

@ -276,7 +276,7 @@ void DIALOG_ERC::OnDeleteOneClick( wxCommandEvent& aEvent )
if( m_notebook->GetSelection() == 0 )
{
// Clear the selection. It may be the selected ERC marker.
m_parent->GetToolManager()->RunAction( EE_ACTIONS::clearSelection, true );
m_parent->GetToolManager()->RunAction( EE_ACTIONS::clearSelection );
m_markerTreeModel->DeleteCurrentItem( true );
@ -632,8 +632,8 @@ void DIALOG_ERC::OnERCItemSelected( wxDataViewEvent& aEvent )
if( !sheet.empty() && sheet != m_parent->GetCurrentSheet() )
{
m_parent->GetToolManager()->RunAction( ACTIONS::cancelInteractive, true );
m_parent->GetToolManager()->RunAction( EE_ACTIONS::clearSelection, true );
m_parent->GetToolManager()->RunAction( ACTIONS::cancelInteractive );
m_parent->GetToolManager()->RunAction( EE_ACTIONS::clearSelection );
m_parent->SetCurrentSheet( sheet );
m_parent->DisplayCurrentSheet();
@ -951,7 +951,7 @@ void DIALOG_ERC::OnSeverity( wxCommandEvent& aEvent )
void DIALOG_ERC::deleteAllMarkers( bool aIncludeExclusions )
{
// Clear current selection list to avoid selection of deleted items
m_parent->GetToolManager()->RunAction( EE_ACTIONS::clearSelection, true );
m_parent->GetToolManager()->RunAction( EE_ACTIONS::clearSelection );
m_markerTreeModel->DeleteItems( false, aIncludeExclusions, false );

2
eeschema/dialogs/dialog_migrate_buses.cpp
View File

@ -68,7 +68,7 @@ DIALOG_MIGRATE_BUSES::DIALOG_MIGRATE_BUSES( SCH_EDIT_FRAME* aParent )
loadGraphData();
updateUi();
aParent->GetToolManager()->RunAction( ACTIONS::zoomFitScreen, true );
aParent->GetToolManager()->RunAction( ACTIONS::zoomFitScreen );
}

6
eeschema/files-io.cpp
View File

@ -286,7 +286,7 @@ bool SCH_EDIT_FRAME::OpenProjectFiles( const std::vector<wxString>& aFileSet, in
// Do not leave g_RootSheet == NULL because it is expected to be
// a valid sheet. Therefore create a dummy empty root sheet and screen.
CreateScreens();
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
msg.Printf( _( "Failed to load '%s'." ), fullFileName );
SetMsgPanel( wxEmptyString, msg );
@ -1287,7 +1287,7 @@ void SCH_EDIT_FRAME::importFile( const wxString& aFileName, int aFileType )
// Do not leave g_RootSheet == NULL because it is expected to be
// a valid sheet. Therefore create a dummy empty root sheet and screen.
CreateScreens();
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
wxString msg = wxString::Format( _( "Error loading schematic '%s'." ), aFileName );
DisplayErrorMessage( this, msg, ioe.What() );
@ -1298,7 +1298,7 @@ void SCH_EDIT_FRAME::importFile( const wxString& aFileName, int aFileType )
catch( const std::exception& exc )
{
CreateScreens();
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
wxString msg = wxString::Format( _( "Unhandled exception occurred loading schematic "
"'%s'." ), aFileName );

2
eeschema/navlib/nl_schematic_plugin_impl.cpp
View File

@ -478,7 +478,7 @@ long NL_SCHEMATIC_PLUGIN_IMPL::SetActiveCommand( std::string commandId )
if( runAction )
{
tool_manager->RunAction( *context, true );
tool_manager->RunAction( *context );
}
}
else

2
eeschema/picksymbol.cpp
View File

@ -305,7 +305,7 @@ void SCH_EDIT_FRAME::ConvertPart( SCH_SYMBOL* aSymbol )
// If selected make sure all the now-included pins are selected
if( aSymbol->IsSelected() )
m_toolManager->RunAction<EDA_ITEM*>( EE_ACTIONS::addItemToSel, true, aSymbol );
m_toolManager->RunAction<EDA_ITEM*>( EE_ACTIONS::addItemToSel, aSymbol );
UpdateItem( aSymbol, false, true );
commit.Push( _( "Convert Symbol" ) );

18
eeschema/sch_edit_frame.cpp
View File

@ -479,7 +479,7 @@ void SCH_EDIT_FRAME::setupTools()
m_toolManager->InitTools();
// Run the selection tool, it is supposed to be always active
m_toolManager->RunAction( EE_ACTIONS::selectionActivate );
m_toolManager->PostAction( EE_ACTIONS::selectionActivate );
GetCanvas()->SetEventDispatcher( m_toolDispatcher );
}
@ -885,7 +885,7 @@ bool SCH_EDIT_FRAME::canCloseWindow( wxCloseEvent& aEvent )
// Note this this will commit *some* pending changes. For instance, the EE_POINT_EDITOR
// will cancel any drag currently in progress, but commit all changes from previous drags.
if( m_toolManager )
m_toolManager->RunAction( ACTIONS::cancelInteractive, true );
m_toolManager->RunAction( ACTIONS::cancelInteractive );
// Shutdown blocks must be determined and vetoed as early as possible
if( KIPLATFORM::APP::SupportsShutdownBlockReason() && aEvent.GetId() == wxEVT_QUERY_END_SESSION
@ -1256,7 +1256,7 @@ void SCH_EDIT_FRAME::OnFindDialogClose()
m_findReplaceDialog->Destroy();
m_findReplaceDialog = nullptr;
m_toolManager->RunAction( ACTIONS::updateFind, true );
m_toolManager->RunAction( ACTIONS::updateFind );
}
@ -1664,7 +1664,7 @@ void SCH_EDIT_FRAME::updateTitle()
void SCH_EDIT_FRAME::initScreenZoom()
{
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
GetScreen()->m_zoomInitialized = true;
}
@ -1965,7 +1965,7 @@ void SCH_EDIT_FRAME::UpdateNetHighlightStatus()
void SCH_EDIT_FRAME::SetScreen( BASE_SCREEN* aScreen )
{
if( m_toolManager )
m_toolManager->RunAction( EE_ACTIONS::clearSelection, true );
m_toolManager->RunAction( EE_ACTIONS::clearSelection );
SCH_BASE_FRAME::SetScreen( aScreen );
GetCanvas()->DisplaySheet( static_cast<SCH_SCREEN*>( aScreen ) );
@ -2067,7 +2067,7 @@ void SCH_EDIT_FRAME::onSize( wxSizeEvent& aEvent )
// We only need this until the frame is done resizing and the final client size is
// established.
Unbind( wxEVT_SIZE, &SCH_EDIT_FRAME::onSize, this );
GetToolManager()->RunAction( ACTIONS::zoomFitScreen, true );
GetToolManager()->RunAction( ACTIONS::zoomFitScreen );
}
// Skip() is called in the base class.
@ -2149,13 +2149,13 @@ void SCH_EDIT_FRAME::DisplayCurrentSheet()
{
wxCHECK( m_toolManager, /* void */ );
m_toolManager->RunAction( ACTIONS::cancelInteractive, true );
m_toolManager->RunAction( EE_ACTIONS::clearSelection, true );
m_toolManager->RunAction( ACTIONS::cancelInteractive );
m_toolManager->RunAction( EE_ACTIONS::clearSelection );
SCH_SCREEN* screen = GetCurrentSheet().LastScreen();
wxCHECK( screen, /* void */ );
m_toolManager->RunAction( EE_ACTIONS::clearSelection, true );
m_toolManager->RunAction( EE_ACTIONS::clearSelection );
SCH_BASE_FRAME::SetScreen( screen );

2
eeschema/schematic_undo_redo.cpp
View File

@ -287,7 +287,7 @@ void SCH_EDIT_FRAME::PutDataInPreviousState( PICKED_ITEMS_LIST* aList )
if( eda_item->Type() == SCH_SHEET_T )
{
if( static_cast<SCH_SHEET*>( eda_item )->GetScreen() == GetScreen() )
GetToolManager()->RunAction( EE_ACTIONS::leaveSheet );
GetToolManager()->PostAction( EE_ACTIONS::leaveSheet );
}
SCH_ITEM* schItem = static_cast<SCH_ITEM*>( eda_item );

2
eeschema/sim/simulator_frame.cpp
View File

@ -613,7 +613,7 @@ void SIMULATOR_FRAME::doCloseWindow()
m_simulator->Clean();
// Cancel a running simProbe or simTune tool
m_schematicFrame->GetToolManager()->RunAction( ACTIONS::cancelInteractive );
m_schematicFrame->GetToolManager()->PostAction( ACTIONS::cancelInteractive );
SaveSettings( config() );

12
eeschema/symbol_editor/symbol_edit_frame.cpp
View File

@ -223,7 +223,7 @@ SYMBOL_EDIT_FRAME::SYMBOL_EDIT_FRAME( KIWAY* aKiway, wxWindow* aParent ) :
bbox.SetSize( max_size_x, max_size_y );
GetCanvas()->GetView()->SetBoundary( bbox );
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
m_acceptedExts.emplace( KiCadSymbolLibFileExtension, &ACTIONS::ddAddLibrary );
DragAcceptFiles( true );
@ -660,8 +660,8 @@ void SYMBOL_EDIT_FRAME::OnSelectUnit( wxCommandEvent& event )
if( ( i == wxNOT_FOUND ) || ( ( i + 1 ) == m_unit ) )
return;
m_toolManager->RunAction( ACTIONS::cancelInteractive, true );
m_toolManager->RunAction( EE_ACTIONS::clearSelection, true );
m_toolManager->RunAction( ACTIONS::cancelInteractive );
m_toolManager->RunAction( EE_ACTIONS::clearSelection );
m_unit = i + 1;
@ -717,7 +717,7 @@ wxString SYMBOL_EDIT_FRAME::SetCurLib( const wxString& aLibNickname )
void SYMBOL_EDIT_FRAME::SetCurSymbol( LIB_SYMBOL* aSymbol, bool aUpdateZoom )
{
m_toolManager->RunAction( EE_ACTIONS::clearSelection, true );
m_toolManager->RunAction( EE_ACTIONS::clearSelection );
GetCanvas()->GetView()->Clear();
delete m_symbol;
@ -748,7 +748,7 @@ void SYMBOL_EDIT_FRAME::SetCurSymbol( LIB_SYMBOL* aSymbol, bool aUpdateZoom )
GetCanvas()->GetView()->ClearHiddenFlags();
if( aUpdateZoom )
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
GetCanvas()->Refresh();
@ -1152,7 +1152,7 @@ void SYMBOL_EDIT_FRAME::emptyScreen()
SetCurSymbol( nullptr, false );
SetScreen( m_dummyScreen );
ClearUndoRedoList();
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
Refresh();
}

8
eeschema/symbol_editor/symbol_editor.cpp
View File

@ -241,7 +241,7 @@ bool SYMBOL_EDIT_FRAME::LoadSymbolFromCurrentLib( const wxString& aAliasName, in
m_SyncPinEdit = GetCurSymbol()->IsMulti() && !GetCurSymbol()->UnitsLocked();
ClearUndoRedoList();
m_toolManager->RunAction( ACTIONS::zoomFitScreen, true );
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
SetShowDeMorgan( GetCurSymbol()->Flatten()->HasConversion() );
if( aUnit > 0 )
@ -265,7 +265,7 @@ bool SYMBOL_EDIT_FRAME::LoadOneLibrarySymbolAux( LIB_SYMBOL* aEntry, const wxStr
return false;
}
m_toolManager->RunAction( ACTIONS::cancelInteractive, true );
m_toolManager->RunAction( ACTIONS::cancelInteractive );
// Symbols from the schematic are edited in place and not managed by the library manager.
if( IsSymbolFromSchematic() )
@ -336,7 +336,7 @@ void SYMBOL_EDIT_FRAME::SaveAll()
void SYMBOL_EDIT_FRAME::CreateNewSymbol( const wxString& inheritFromSymbolName )
{
m_toolManager->RunAction( ACTIONS::cancelInteractive, true );
m_toolManager->RunAction( ACTIONS::cancelInteractive );
wxArrayString rootSymbols;
wxString lib = getTargetLib();
@ -1032,7 +1032,7 @@ bool SYMBOL_EDIT_FRAME::saveLibrary( const wxString& aLibrary, bool aNewFile )
SCH_IO_MGR::SCH_FILE_T fileType = SCH_IO_MGR::SCH_FILE_T::SCH_KICAD;
PROJECT& prj = Prj();
m_toolManager->RunAction( ACTIONS::cancelInteractive, true );
m_toolManager->RunAction( ACTIONS::cancelInteractive );
if( !aNewFile && ( aLibrary.empty() || !prj.SchSymbolLibTable()->HasLibrary( aLibrary ) ) )
{

Some files were not shown because too many files have changed in this diff Show More