API: Clear footprint caches when making changes

pcbnew/api/api_handler_pcb.cpp

@@ -478,6 +478,16 @@ HANDLER_RESULT<ItemRequestStatus> API_HANDLER_PCB::handleCreateUpdateItemsIntern
         {
             BOARD_ITEM* boardItem = *optItem;
             commit->Modify( boardItem );
+
+            // Normally this is done by the footprint methods SetPosition, SetOrientation, etc
+            // Since the API is just using the assignment operator, we need to wipe out all the
+            // caches so that they will be rebuilt with any changes to the geometry made by the API
+            if( boardItem->Type() == PCB_FOOTPRINT_T )
+            {
+                auto boardFp = static_cast<FOOTPRINT*>( boardItem );
+                boardFp->InvalidateGeometryCaches();
+            }
+
             boardItem->CopyFrom( item.get() );
             boardItem->Serialize( newItem );
         }

pcbnew/footprint.cpp

@@ -955,6 +955,17 @@ void FOOTPRINT::CopyFrom( const BOARD_ITEM* aOther )
 }
 
 
+void FOOTPRINT::InvalidateGeometryCaches()
+{
+    m_boundingBoxCacheTimeStamp = 0;
+    m_textExcludedBBoxCacheTimeStamp = 0;
+    m_hullCacheTimeStamp = 0;
+
+    m_courtyard_cache_back_hash.Clear();
+    m_courtyard_cache_front_hash.Clear();
+}
+
+
 bool FOOTPRINT::IsConflicting() const
 {
     return HasFlag( COURTYARD_CONFLICT );

pcbnew/footprint.h

@@ -145,6 +145,9 @@ public:
         return aItem && aItem->Type() == PCB_FOOTPRINT_T;
     }
 
+    /// Resets the caches for this footprint, for example if it was modified via the API
+    void InvalidateGeometryCaches();
+
     LSET GetPrivateLayers() const { return m_privateLayers; }
     void SetPrivateLayers( const LSET& aLayers ) { m_privateLayers = aLayers; }