AllSpiceMirrors/kicad
7
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-04 23:35:31 +00:00
Files Issues Releases Activity

Pcbnew, performance fix: rebuild the pad view only when mandatory.

Browse Source 
The LAYER_PAD_HOLEWALLS shape needs a rebuild only when the zoom level changes.
So keep trace of the last GAL zoom level to rebuild the shape, and only rebuild
the view when needed
This commit is contained in:
jean-pierre charras 2025-03-26 13:18:22 +01:00
parent 7bd4fa3fa6
commit 3e51b2c647
2 changed files with 15 additions and 2 deletions

14
pcbnew/pad.cpp
View File

@ -65,6 +65,7 @@
#include "pcbnew_settings.h"
#include <pcb_group.h>
#include <gal/graphics_abstraction_layer.h>
using KIGFX::PCB_PAINTER;
using KIGFX::PCB_RENDER_SETTINGS;
@ -108,6 +109,8 @@ PAD::PAD( FOOTPRINT* parent ) :
for( PCB_LAYER_ID layer : LAYER_RANGE( F_Cu, B_Cu, BoardCopperLayerCount() ) )
m_zoneLayerOverrides[layer] = ZLO_NONE;
m_lastGalZoolLevel = 0.0;
}
@ -1786,9 +1789,16 @@ double PAD::ViewGetLOD( int aLayer, const KIGFX::VIEW* aView ) const
return lodScaleForThreshold( aView, minSize, pcbIUScale.mmToIU( 0.5 ) );
}
// Hole walls always need a repaint when zoom changes
// Hole walls always need a repaint when zoom level changes after the last
// LAYER_PAD_HOLEWALLS shape rebuild
if( aLayer == LAYER_PAD_HOLEWALLS )
aView->Update( this, KIGFX::REPAINT );
{
if( aView->GetGAL()->GetZoomFactor() != m_lastGalZoolLevel )
{
aView->Update( this, KIGFX::REPAINT );
m_lastGalZoolLevel = aView->GetGAL()->GetZoomFactor();
}
}
VECTOR2L padSize = GetShape( pcbLayer ) != PAD_SHAPE::CUSTOM
? VECTOR2L( GetSize( pcbLayer ) ) : GetBoundingBox().GetSize();

3
pcbnew/pad.h
View File

@ -948,6 +948,9 @@ private:
mutable std::mutex m_polyBuildingLock;
mutable LAYER_POLYGON_MAP m_effectivePolygons;
mutable int m_effectiveBoundingRadius;
// Last zoom level used to draw the pad: the LAYER_PAD_HOLEWALLS layer shape
// depend on the zoom level. So keep trace on the last used zoom level
mutable double m_lastGalZoolLevel;
int m_subRatsnest; // Variable used to handle subnet (block) number in
// ratsnest computations