From 4ce9648d34fb568f64957a06808a7387f58a09b7 Mon Sep 17 00:00:00 2001
From: jean-pierre charras <jp.charras@wanadoo.fr>
Date: Fri, 23 Aug 2024 09:54:29 +0200
Subject: [PATCH] Fix a few minor Coverity and compil warnings.
---
gerbview/rs274d.cpp | 2 +-
kicad/kicad_manager_frame.cpp | 2 +-
pcbnew/board_commit.cpp | 3 ++-
pcbnew/sel_layer.cpp | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/gerbview/rs274d.cpp b/gerbview/rs274d.cpp
index 9d5e8640e4..a1f9f68ee2 100644
--- a/gerbview/rs274d.cpp
+++ b/gerbview/rs274d.cpp
@@ -298,7 +298,7 @@ void fillArcGBRITEM( GERBER_DRAW_ITEM* aGbrItem, int Dcode_index, const VECTOR2I
aGbrItem->SetLayerPolarity( aLayerNegative );
}
-#include <wx/log.h>
+
/**
* Create an arc G code when found in polygon outlines.
*
diff --git a/kicad/kicad_manager_frame.cpp b/kicad/kicad_manager_frame.cpp
index 0fd2ca1236..28f74dca6c 100644
--- a/kicad/kicad_manager_frame.cpp
+++ b/kicad/kicad_manager_frame.cpp
@@ -206,7 +206,7 @@ KICAD_MANAGER_FRAME::KICAD_MANAGER_FRAME( wxWindow* parent, const wxString& titl
m_auimgr.SetManagedWindow( this );
m_auimgr.SetFlags( wxAUI_MGR_LIVE_RESIZE );
- m_auimgr.AddPane( m_mainToolBar, EDA_PANE().HToolbar().Name( "MainToolbar" ).Left()
+ m_auimgr.AddPane( m_mainToolBar, EDA_PANE().VToolbar().Name( "MainToolbar" ).Left()
.Layer( 2 ) );
// BestSize() does not always set the actual pane size of m_leftWin to the required value.
diff --git a/pcbnew/board_commit.cpp b/pcbnew/board_commit.cpp
index 3f6d75cce4..1529b94877 100644
--- a/pcbnew/board_commit.cpp
+++ b/pcbnew/board_commit.cpp
@@ -79,7 +79,8 @@ BOARD_COMMIT::BOARD_COMMIT( TOOL_MANAGER* aMgr ) :
BOARD_COMMIT::BOARD_COMMIT( TOOL_MANAGER* aMgr, bool aIsBoardEditor ) :
m_toolMgr( aMgr ),
- m_isBoardEditor( aIsBoardEditor )
+ m_isBoardEditor( aIsBoardEditor ),
+ m_isFootprintEditor( false )
{
}
diff --git a/pcbnew/sel_layer.cpp b/pcbnew/sel_layer.cpp
index 7c96deff90..3ab7707927 100644
--- a/pcbnew/sel_layer.cpp
+++ b/pcbnew/sel_layer.cpp
@@ -383,7 +383,7 @@ public:
{
LAYER_PAIR_INFO layerPairInfo{ aLayerPair, true, std::nullopt };
- const bool added = m_layerPairSettings.AddLayerPair( std::move( layerPairInfo ) );
+ const bool added = m_layerPairSettings.AddLayerPair( layerPairInfo );
if( added )
{