AllSpiceMirrors/kicad
7
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-17 08:39:17 +00:00
Files Issues Releases Activity

Fix a side effect of commit 513d659c (master) or 55fafe34 (8.0 branch)

Browse Source 
This commit modify the order of end points of flipped graphic lines, and
create a DRC issue for flipped footprints (if flipped before this commit).
For segments inside a footprint, the "old" way to flip a segment is now
reused.
Expecting this ugly fix is only temporary.
This commit is contained in:
jean-pierre charras 2024-09-03 16:42:33 +02:00
parent 89a3b7baa5
commit 6bc51781b8
1 changed files with 28 additions and 0 deletions

28
pcbnew/footprint.cpp
View File

@ -2329,8 +2329,36 @@ void FOOTPRINT::Flip( const VECTOR2I& aCentre, bool aFlipLeftRight )
// Reverse mirror footprint graphics and texts.
for( BOARD_ITEM* item : m_drawings )
{
item->Flip( m_pos, false );
#if 1
// This code is expected to be temporary: a better but more complex fix should
// be in drc_test_library_parity.cpp
// Before commit 513d659c (master) or 55fafe34 (8.0 branch)
// ( (28 08 2024: Fix incorrect flip for graphic segments)
// segments ends were swapped (for an obscure reason) creating an issue for
// segments living on a board.
// They are now not flipped, but it has a side effect for footprints, especially
// in DRC test for library parity, any footprint flipped before this commit does
// not match library.
// so to avoid this issue, swap the ends of segments, like before.
// This is ugly fix, until the DRC test can handle swapped and not swapped ends
if( item->Type() == PCB_SHAPE_T )
{
PCB_SHAPE* shape = static_cast<PCB_SHAPE*>( item );
if( shape->GetShape() == SHAPE_T::SEGMENT )
{
VECTOR2I start = shape->GetStart();
VECTOR2I end = shape->GetEnd();
shape->SetStart( end );
shape->SetEnd( start );
}
}
#endif
}
// Now rotate 180 deg if required
if( aFlipLeftRight )
Rotate( aCentre, ANGLE_180 );