From a8a1b0801361dc16895d75240943f11fddcaa22b Mon Sep 17 00:00:00 2001
From: Jeff Young <jeff@rokeby.ie>
Date: Thu, 20 Feb 2025 17:41:04 +0000
Subject: [PATCH] Make sure protobuf API stays consistent.
---
api/proto/board/board_types.proto | 2 ++
api/proto/common/types/base_types.proto | 6 ++++--
common/eda_text.cpp | 1 +
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/api/proto/board/board_types.proto b/api/proto/board/board_types.proto
index f01a94aa10..6397292c04 100644
--- a/api/proto/board/board_types.proto
+++ b/api/proto/board/board_types.proto
@@ -768,6 +768,8 @@ message Field
FieldId id = 1;
string name = 2;
BoardText text = 3;
+
+ // Since 9.0.1
bool visible = 4;
}
diff --git a/api/proto/common/types/base_types.proto b/api/proto/common/types/base_types.proto
index dbef5f95c6..1bb3b17cbe 100644
--- a/api/proto/common/types/base_types.proto
+++ b/api/proto/common/types/base_types.proto
@@ -291,8 +291,10 @@ message TextAttributes
bool italic = 7;
bool bold = 8;
bool underlined = 9;
- // Visible now exposed only at the field level
- // bool visible = 10;
+
+ // Deprecated since 9.0.1 (text items are now always visible, only Fields can be hidden)
+ bool visible = 10;
+
bool mirrored = 11;
bool multiline = 12;
bool keep_upright = 13;
diff --git a/common/eda_text.cpp b/common/eda_text.cpp
index 1dd4ceab08..7ce6cc57dd 100644
--- a/common/eda_text.cpp
+++ b/common/eda_text.cpp
@@ -210,6 +210,7 @@ void EDA_TEXT::Serialize( google::protobuf::Any &aContainer ) const
attrs->set_italic( IsItalic() );
attrs->set_bold( IsBold() );
attrs->set_underlined( GetAttributes().m_Underlined );
+ attrs->set_visible( true );
attrs->set_mirrored( IsMirrored() );
attrs->set_multiline( IsMultilineAllowed() );
attrs->set_keep_upright( IsKeepUpright() );