AllSpiceMirrors/kicad
7
Fork 0
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-21 09:31:42 +00:00
Files Issues Releases Activity

Sync Sheet Pins: Refactor SHEET_SYNCHRONIZATION_MODEL to use GetCount() for item count management

Browse Source 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19592
This commit is contained in:
Ethan Chien 2025-01-12 17:31:51 +08:00
parent a12496a04b
commit ad48ce1147
2 changed files with 12 additions and 4 deletions

13
eeschema/sync_sheet_pin/sheet_synchronization_model.cpp
View File

@ -107,7 +107,7 @@ void SHEET_SYNCHRONIZATION_MODEL::RemoveItems( wxDataViewItemArray const& aItems
bool SHEET_SYNCHRONIZATION_MODEL::AppendNewItem( std::shared_ptr<SHEET_SYNCHRONIZATION_ITEM> aItem )
{
m_items.push_back( std::move( aItem ) );
RowAppended();
Reset( GetCount() );
DoNotify();
return true;
}
@ -116,7 +116,7 @@ bool SHEET_SYNCHRONIZATION_MODEL::AppendNewItem( std::shared_ptr<SHEET_SYNCHRONI
bool SHEET_SYNCHRONIZATION_MODEL::AppendItem( std::shared_ptr<SHEET_SYNCHRONIZATION_ITEM> aItem )
{
m_items.push_back( std::move( aItem ) );
RowAppended();
Reset( GetCount() );
return true;
}
@ -168,7 +168,7 @@ SHEET_SYNCHRONIZATION_ITE_PTR SHEET_SYNCHRONIZATION_MODEL::TakeItem( wxDataViewI
std::shared_ptr<SHEET_SYNCHRONIZATION_ITEM> item = m_items[row];
m_items.erase( m_items.begin() + row );
OnRowSelected( {} );
RowDeleted( row );
Reset( GetCount() );
return item;
}
@ -205,7 +205,7 @@ void SHEET_SYNCHRONIZATION_MODEL::OnRowSelected( std::optional<unsigned> aRow )
void SHEET_SYNCHRONIZATION_MODEL::UpdateItems( SHEET_SYNCHRONIZATION_ITEM_LIST aItems )
{
m_items = std::move( aItems );
Reset( m_items.size() );
Reset( GetCount() );
}
@ -221,3 +221,8 @@ void SHEET_SYNCHRONIZATION_MODEL::DoNotify()
for( const auto& notifier : m_notifiers )
notifier->Notify();
}
unsigned int SHEET_SYNCHRONIZATION_MODEL::GetCount() const
{
return m_items.size();
}

3
eeschema/sync_sheet_pin/sheet_synchronization_model.h
View File

@ -112,6 +112,9 @@ public:
std::optional<unsigned int> GetSelectedIndex() const { return m_selectedIndex; }
unsigned int GetCount() const override;
private:
SHEET_SYNCHRONIZATION_ITEM_LIST m_items;
std::optional<unsigned> m_selectedIndex;