7
mirror of https://gitlab.com/kicad/code/kicad.git synced 2025-04-21 00:21:25 +00:00

Fix some signed/unsigned comparisons

This commit is contained in:
Seth Hillbrand 2024-07-08 13:38:11 -07:00
parent 14ccadd2a9
commit b1093f1daf

View File

@ -365,7 +365,7 @@ void VIEW::Remove( VIEW_ITEM* aItem )
std::vector<VIEW_ITEM*>::iterator item = m_allItems->end();
int cachedIndex = aItem->m_viewPrivData->m_cachedIndex;
if( cachedIndex >= 0 && cachedIndex < m_allItems->size()
if( cachedIndex >= 0 && cachedIndex < static_cast<ssize_t>( m_allItems->size() )
&& ( *m_allItems )[cachedIndex] == aItem )
{
item = m_allItems->begin() + cachedIndex;
@ -392,7 +392,7 @@ void VIEW::Remove( VIEW_ITEM* aItem )
} );
// Update cached indices
for( int idx = 0; idx < m_allItems->size(); idx++ )
for( size_t idx = 0; idx < m_allItems->size(); idx++ )
( *m_allItems )[idx]->m_viewPrivData->m_cachedIndex = idx;
s_gcCounter = 0;