From d0b22d21bb27f680941a52ca25c1bde683107c30 Mon Sep 17 00:00:00 2001 From: Jon Evans <jon@craftyjon.com> Date: Tue, 4 Mar 2025 21:12:11 -0500 Subject: [PATCH] Switch to operator= for item updates Fixes https://gitlab.com/kicad/code/kicad/-/issues/20206 --- pcbnew/api/api_handler_pcb.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pcbnew/api/api_handler_pcb.cpp b/pcbnew/api/api_handler_pcb.cpp index 1a1f8f95d2..8e7b5781f0 100644 --- a/pcbnew/api/api_handler_pcb.cpp +++ b/pcbnew/api/api_handler_pcb.cpp @@ -478,7 +478,7 @@ HANDLER_RESULT<ItemRequestStatus> API_HANDLER_PCB::handleCreateUpdateItemsIntern { BOARD_ITEM* boardItem = *optItem; commit->Modify( boardItem ); - boardItem->SwapItemData( item.get() ); + *boardItem = *item; boardItem->Serialize( newItem ); }