design blocks: move settings save out of destructor

eeschema/eeschema_config.cpp

@@ -338,6 +338,8 @@ void SCH_EDIT_FRAME::SaveSettings( APP_SETTINGS_BASE* aCfg )
             cfg->m_AuiPanels.design_blocks_panel_float_height = designBlocksPane.floating_size.y;
             cfg->m_AuiPanels.design_blocks_panel_float_width = designBlocksPane.floating_size.x;
         }
+
+        m_designBlocksPane->SaveSettings();
     }
 }
 

eeschema/widgets/design_block_pane.cpp

@@ -154,6 +154,12 @@ void DESIGN_BLOCK_PANE::UpdateCheckboxes()
 }
 
 
+void DESIGN_BLOCK_PANE::SaveSettings()
+{
+    m_chooserPanel->SaveSettings();
+}
+
+
 LIB_ID DESIGN_BLOCK_PANE::GetSelectedLibId( int* aUnit ) const
 {
     return m_chooserPanel->GetSelectedLibId( aUnit );

eeschema/widgets/design_block_pane.h

@@ -52,6 +52,8 @@ public:
 
     ~DESIGN_BLOCK_PANE() override;
 
+    void SaveSettings();
+
     /**
      * To be called after this dialog returns from ShowModal().
      *

eeschema/widgets/panel_design_block_chooser.cpp

@@ -159,7 +159,11 @@ PANEL_DESIGN_BLOCK_CHOOSER::~PANEL_DESIGN_BLOCK_CHOOSER()
     m_open_libs_timer->Stop();
     delete m_dbl_click_timer;
     delete m_open_libs_timer;
+}
 
+
+void PANEL_DESIGN_BLOCK_CHOOSER::SaveSettings()
+{
     g_designBlockSearchString = m_tree->GetSearchString();
 
     if( EESCHEMA_SETTINGS* cfg = dynamic_cast<EESCHEMA_SETTINGS*>( Kiface().KifaceSettings() ) )

eeschema/widgets/panel_design_block_chooser.h

@@ -52,6 +52,8 @@ public:
 
     ~PANEL_DESIGN_BLOCK_CHOOSER();
 
+    void SaveSettings();
+
     void OnChar( wxKeyEvent& aEvent );
 
     void FinishSetup();