mirror of
https://gitlab.com/kicad/code/kicad.git
synced 2024-11-24 00:34:47 +00:00
66f6168163
Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
61 lines
1.9 KiB
C++
61 lines
1.9 KiB
C++
/*
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
*
|
|
* Copyright (C) 2020-2023 KiCad Developers, see AUTHORS.txt for contributors.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, you may find one here:
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
*/
|
|
|
|
#ifndef DIALOG_BOOK_REPORTER_H
|
|
#define DIALOG_BOOK_REPORTER_H
|
|
|
|
#include <dialogs/dialog_book_reporter_base.h>
|
|
|
|
class KIWAY_PLAYER;
|
|
class WX_HTML_REPORT_BOX;
|
|
class wxHtmlLinkEvent;
|
|
|
|
/**
|
|
* Event sent to parent when dialog is mode-less.
|
|
*/
|
|
wxDECLARE_EVENT( EDA_EVT_CLOSE_DIALOG_BOOK_REPORTER, wxCommandEvent );
|
|
|
|
class DIALOG_BOOK_REPORTER : public DIALOG_BOOK_REPORTER_BASE
|
|
{
|
|
public:
|
|
DIALOG_BOOK_REPORTER( KIWAY_PLAYER* aParent, const wxString& aName,
|
|
const wxString& aDialogTitle );
|
|
|
|
void OnClose( wxCloseEvent& aEvent ) override;
|
|
|
|
void OnErrorLinkClicked( wxHtmlLinkEvent& aEvent );
|
|
|
|
void DeleteAllPages();
|
|
|
|
WX_HTML_REPORT_BOX* AddHTMLPage( const wxString& aTitle );
|
|
|
|
wxPanel* AddBlankPage( const wxString& aTitle );
|
|
|
|
int GetPageCount() const;
|
|
|
|
protected:
|
|
KIWAY_PLAYER* m_frame;
|
|
};
|
|
|
|
#endif // DIALOG_BOOK_REPORTER_H
|