0
mirror of https://github.com/torvalds/GuitarPedal.git synced 2026-08-18 13:13:35 +00:00
Files
Linus Torvalds 0c1b9c3db3 Split Software/ into the four things it actually was
'Software' was the directory everything that was not KiCad ended up in,
which stopped describing anything a while ago - Validation and the web
app are software too.  Worse, it put the shared parts inside the
firmware, where they read as the firmware's own.

They are not.  Effects/ has three consumers built from it: the firmware,
Validation's bench, and the web app's controls, all generated from the
same POT: comments by gen_effects.py.  Audio/ has two - the bench
compiles the same biquads, the same envelope followers and the same
single_sample(), which is the whole reason a measurement on a
workstation says anything about the pedal.  Neither belongs under
Firmware/, so neither is under it any more:

  Effects/    one file per effect
  Audio/      the DSP they are built from, and the audio loop
  Firmware/   the rest of what runs on the pedal, and the submodules
  WebMIDI/    the web app
  scripts/    what the build runs
  Validation/ unchanged
  Hardware/, Documentation/, Images/

CMakeLists.txt and the wrapper Makefile move to the top with them,
because the build now consumes four of those directories and generates
into a fifth.  board.local and build/ come along; MIDI_CC_MAP.md is
generated into Documentation/ rather than into the old Software/ root.

scripts/ goes with the build rather than staying under the firmware,
because six of the ten had nothing to do with the firmware: gen_effects.py
reads Effects/ and writes to three different places, pow2/log2/quarter_sine
generate Audio/'s tables, check-readme.py compares Effects/ against the
README, and server.py serves the web app.  Four of them are invoked from
Validation, which was reaching into Firmware/ for tooling - the same
burying this commit is undoing.  The four that really are about the
firmware are ELF checks the top-level build drives anyway, and a second
scripts directory would only be a second place to look.

C includes say "Audio/foo.h" and the generated map says
"Effects/bar.h", with the repository root on the include path for both
the firmware and the bench.  Spelling the directory out rather than
relying on a bare name is what keeps Audio/cycles.h shimmable: a quoted
include searches the including file's own directory first.

The submodules are renamed as well as moved.  git mv updates their paths
but leaves the section names, and 'Software/pico-sdk' surviving in
.gitmodules would be the word this commit removes, still load-bearing.
That meant the nested modules under pico-sdk too - six .git files
pointing into .git/modules/Software - which is why 'git submodule update
--init --recursive' is worth running once after pulling this.

Verified rather than assumed: a clean configure and build, make check
(failing only on the missing-eeprom case it already failed on),
check-effects, all four analysis pages reproducing every series and
drawing every chart, and a flash to the board that still measures a
routed reverb where it did before.

One latent bug fell out of it.  bench/coeff declared only quarter_sine.h
of the three generated math tables, and Audio/util.h includes pow2.h and
log2.h as well - so building that target with an empty gen/ could never
have worked.  'make bench' builds bench/bench first, which generates all
three, so it stayed hidden until this rebuilt everything from nothing.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2026-08-11 13:48:26 -07:00

67 lines
1.9 KiB
C

// NAME: Pitch [PITCH]
// PRIORITY: 100
// MIX: POWER // shifted, so it decorrelates almost immediately
// POT: "Octave" LINEAR(-2.0 2.0) = 1.0
// POT: "Feedback" LINEAR(0.0 1.0) = 0.5
// DEFAULT_MIX: 0.5
//
// Entirely random pitch shifting effect walking the
// sample buffer at varying speeds, and hiding the
// discontinuities in the sequence by picking two
// different delays, and multiplying them with sin/cos
//
// sin/cos are zero at the respective discontinuities,
// and the signal power is proportional to the square
// of the voltage. With sin^2 * cos^2 = 1, the result
// should be a unity signal power gain.
//
#define DISCONT_SHIFT 12
#define DISCONT_STEPS (1 << DISCONT_SHIFT)
struct {
float step, feedback;
unsigned phase, idx;
float array[4*DISCONT_STEPS];
} pitch;
static void pitch_init(unsigned char pot[10])
{
// Which direction do we walk the samples?
// Walking backwards lowers the pitch
// Walking forwards raises the pitch
// Staying at the same delay keeps the pitch the same
//
float step = pow2(pitch_octave_pot(pot)); // 0.25 .. 4
pitch.step = step - 1; // -0.75 .. 3
pitch.feedback = pitch_feedback_pot(pot);
}
// i is discontinuous when sin**2 is 0
// ni is discontinuous when cos**2 (aka 1-sin**2) is 0
static float pitch_step(float in)
{
const u32 mask = DISCONT_STEPS-1;
u32 phase = pitch.phase++;
u32 i = phase & mask;
u32 ni = (i + DISCONT_STEPS/2) & mask;
// The 31 is because we only use half the phase,
// so sin walks 0..0.5 and cos walks 0.25..0.75
phase <<= 31-DISCONT_SHIFT;
struct sincos w = fastsincos(u32_to_fraction(phase));
float step = pitch.step;
float delay = (step > 0) ? DISCONT_STEPS*step : 1;
float d1 = sample_array_read(delay - i*step, &pitch.idx, pitch.array) * w.sin;
float d2 = sample_array_read(delay - ni*step, &pitch.idx, pitch.array) * w.cos;
float out = d1+d2;
sample_array_write(linear(pitch.feedback, in, out), &pitch.idx, pitch.array);
return out;
}