You've already forked torvalds-GuitarPedal
mirror of
https://github.com/torvalds/GuitarPedal.git
synced 2026-08-18 13:13:35 +00:00
0c1b9c3db3
'Software' was the directory everything that was not KiCad ended up in, which stopped describing anything a while ago - Validation and the web app are software too. Worse, it put the shared parts inside the firmware, where they read as the firmware's own. They are not. Effects/ has three consumers built from it: the firmware, Validation's bench, and the web app's controls, all generated from the same POT: comments by gen_effects.py. Audio/ has two - the bench compiles the same biquads, the same envelope followers and the same single_sample(), which is the whole reason a measurement on a workstation says anything about the pedal. Neither belongs under Firmware/, so neither is under it any more: Effects/ one file per effect Audio/ the DSP they are built from, and the audio loop Firmware/ the rest of what runs on the pedal, and the submodules WebMIDI/ the web app scripts/ what the build runs Validation/ unchanged Hardware/, Documentation/, Images/ CMakeLists.txt and the wrapper Makefile move to the top with them, because the build now consumes four of those directories and generates into a fifth. board.local and build/ come along; MIDI_CC_MAP.md is generated into Documentation/ rather than into the old Software/ root. scripts/ goes with the build rather than staying under the firmware, because six of the ten had nothing to do with the firmware: gen_effects.py reads Effects/ and writes to three different places, pow2/log2/quarter_sine generate Audio/'s tables, check-readme.py compares Effects/ against the README, and server.py serves the web app. Four of them are invoked from Validation, which was reaching into Firmware/ for tooling - the same burying this commit is undoing. The four that really are about the firmware are ELF checks the top-level build drives anyway, and a second scripts directory would only be a second place to look. C includes say "Audio/foo.h" and the generated map says "Effects/bar.h", with the repository root on the include path for both the firmware and the bench. Spelling the directory out rather than relying on a bare name is what keeps Audio/cycles.h shimmable: a quoted include searches the including file's own directory first. The submodules are renamed as well as moved. git mv updates their paths but leaves the section names, and 'Software/pico-sdk' surviving in .gitmodules would be the word this commit removes, still load-bearing. That meant the nested modules under pico-sdk too - six .git files pointing into .git/modules/Software - which is why 'git submodule update --init --recursive' is worth running once after pulling this. Verified rather than assumed: a clean configure and build, make check (failing only on the missing-eeprom case it already failed on), check-effects, all four analysis pages reproducing every series and drawing every chart, and a flash to the board that still measures a routed reverb where it did before. One latent bug fell out of it. bench/coeff declared only quarter_sine.h of the three generated math tables, and Audio/util.h includes pow2.h and log2.h as well - so building that target with an empty gen/ could never have worked. 'make bench' builds bench/bench first, which generates all three, so it stayed hidden until this rebuilt everything from nothing. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
33 lines
1.1 KiB
C
33 lines
1.1 KiB
C
// NAME: Vibrato [VIB]
|
|
// PRIORITY: 70
|
|
// MIX: POWER // a modulated delay - the wet is the dry displaced in time
|
|
// POT: "Rate" FREQUENCY(0.1 8.0) = 2.0 Hz
|
|
// POT: "Depth" LINEAR(0.0 5.0) = 0.875 ms
|
|
// Vibrato: LFO-modulated delay line for a classic Doppler shift.
|
|
// Blending dry signal with the wet signal produces a rich chorus-like effect.
|
|
// At 100% wet only the pitch-shifted signal is audible; fun for rotary speaker emulation.
|
|
|
|
#define VIBRATO_CENTER_SAMPLES (6.0f * SAMPLES_PER_MSEC)
|
|
|
|
static struct {
|
|
struct lfo_state lfo;
|
|
float depth; // delay amplitude in samples
|
|
unsigned int idx;
|
|
float samples[1024]; // ~21ms at 48kHz; max read = center(6ms) + depth(5ms) = 528 samples
|
|
} vib;
|
|
|
|
static void vib_init(unsigned char pot[10])
|
|
{
|
|
set_lfo_freq(&vib.lfo, vib_rate_pot(pot));
|
|
vib.depth = vib_depth_pot(pot) * SAMPLES_PER_MSEC;
|
|
|
|
}
|
|
|
|
static float vib_step(float in)
|
|
{
|
|
float d = VIBRATO_CENTER_SAMPLES + vib.depth * lfo_step(&vib.lfo, lfo_sinewave);
|
|
sample_array_write(in, &vib.idx, vib.samples);
|
|
float wet = sample_array_read(d, &vib.idx, vib.samples);
|
|
return wet;
|
|
}
|