You've already forked torvalds-GuitarPedal
mirror of
https://github.com/torvalds/GuitarPedal.git
synced 2026-06-07 04:55:36 +00:00
c88f369fd3
Bah. It wasn't just the echo that had gotten messed up in the
conversion to the new and more legible pot metadata.
The *new* metadata defaults are pretty clear and obvious, but the old
ones were not, and I clearly should have been a whole lot more careful
in converting them, because half the effects had various messed up
default values. Lots of "zero meant pot at noon - so float value 0.5"
turned into just plain "zero means zero".
So I do think the new model is a lot better, but "Mistakes were made".
I tried to go through every effect and double-check it against what it
used to be. Not that all the old defaults were sane (I'm looking at
you, boost effect), but the metadata conversion wasn't meant to change
them.
Fixes: 9c208692f7 ("Convert effects to metadata-driven boiler plate generation")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
40 lines
1.1 KiB
C
40 lines
1.1 KiB
C
// NAME: Phaser [PHSR]
|
|
// PRIORITY: 50
|
|
// POT: "LFO" FREQUENCY(25.0 2000.0) = 270.0 ms
|
|
// POT: "Feedback" LINEAR(0.0 0.75) = 0.376
|
|
// POT: "Freq" FREQUENCY(220.0 6460.0) = 1000.0 Hz
|
|
// POT: "Q" LINEAR(0.25 2.0) = 1.125
|
|
struct {
|
|
struct lfo_state lfo;
|
|
struct biquad_coeff coeff;
|
|
float s0[2], s1[2], s2[2], s3[2];
|
|
float center_f, octaves, Q, feedback;
|
|
} phaser;
|
|
|
|
void phaser_init(unsigned char pot[10])
|
|
{
|
|
float ms = phaser_pot0(pot[0]); // 25ms .. 2s
|
|
set_lfo_ms(&phaser.lfo, ms);
|
|
phaser.feedback = phaser_pot1(pot[1]);
|
|
|
|
phaser.center_f = phaser_pot2(pot[2]); // 220Hz .. 6.5kHz
|
|
phaser.octaves = 0.5; // 155Hz .. 9kHz
|
|
phaser.Q = phaser_pot3(pot[3]);
|
|
}
|
|
|
|
float phaser_step(float in)
|
|
{
|
|
float lfo = lfo_step(&phaser.lfo, lfo_triangle);
|
|
float freq = pow2(lfo*phaser.octaves) * phaser.center_f;
|
|
float out;
|
|
|
|
_biquad_allpass_filter(&phaser.coeff, _w0(freq), phaser.Q);
|
|
|
|
out = in + phaser.feedback * phaser.s3[0];
|
|
out = biquad_step_df1(&phaser.coeff, out, phaser.s0, phaser.s1);
|
|
out = biquad_step_df1(&phaser.coeff, out, phaser.s1, phaser.s2);
|
|
out = biquad_step_df1(&phaser.coeff, out, phaser.s2, phaser.s3);
|
|
|
|
return tanhf(in + out);
|
|
}
|