You've already forked torvalds-GuitarPedal
mirror of
https://github.com/torvalds/GuitarPedal.git
synced 2026-09-03 16:12:36 +00:00
3cca957160
Unplug a volume pedal and the rig goes silent, and stays silent. The normalling contacts ground the wiper pin, so an unplugged jack reads as a treadle at its heel stop - which is a legitimate position and gets acted on, one last time, on the way to nothing. Auto then notices the jack is empty and stops driving, which is correct and far too late: the volume is already at -40dB and nothing is going to move it again. Nothing can stop that first part happening. There is no way to tell an empty jack from a heel stop until a probe says so, and by then it has been acted on. What can be done is undoing it, so a treadle that stops being a treadle puts every pot it was driving back. To the default rather than to whatever the value was before. "Before" would have to survive scene loads and rebinding to be worth anything, and the default is already the answer to "where does this sit when nothing is driving it" - the same one reset_effect() and an unrouted effect give. For Volume that is 0dB, which is the case that matters. Also: the probe's answer stopped going away. It is about one probe, so anything that moves the menu afterwards clears it - a person picking something, or the pedal writing the setting itself, which sets .value from script and fires no event. Left up, "cannot tell" read as a standing property of the jack rather than as one reply to one question. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>