AllSpice-Demos/Action-Component-Check-Demo
AllSpice-Demos/Action-Component-Check-Demo
13
Fork 0
Files Issues Design Reviews 3 Actions NEW Releases Activity

Make warnings require passing state #2

Open
allspice-kyle wants to merge 4 commits from strict_error_check into develop
pull from: strict_error_check
merge into: AllSpice-Demos:develop
Conversation 1 Commits 4 Files Changed 2 +2 -1
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 99097b8b01 - Show all commits

2
.allspice/component_validation.py
View File

@ -91,7 +91,7 @@ with open(components_csv_path, newline="") as components_csv:
min_temp, max_temp = [int(x.strip("¡ãC ")) for x in row["Temperature"].split(" to ")] min_temp, max_temp = [int(x.strip("¡ãC ")) for x in row["Temperature"].split(" to ")]
except ValueError: except ValueError:
logger.warning( logger.warning(
f"Designators(s) {row['Designator']} have malformed `Temperature` attribute: !" f"Designators(s) {row['Designator']} have malformed `Temperature` attribute: {row['Temperature']}!"
) )
component.warnings.append(f"Malformed `Temperature` attribute: `{row['Temperature']}`!") component.warnings.append(f"Malformed `Temperature` attribute: `{row['Temperature']}`!")
else: else:

1
.allspice/workflows/bom-gen.yml
View File

@ -53,6 +53,7 @@ jobs:
run: .allspice/component_validation.py ./bom.csv run: .allspice/component_validation.py ./bom.csv
- name: Post Comment on Design Review - name: Post Comment on Design Review
if: always() # Generate the report even if the last step failed.
uses: https://hub.allspice.io/Actions/post-dr-comment@v0.1 uses: https://hub.allspice.io/Actions/post-dr-comment@v0.1
with: with:
# The path to the markdown file containing the comment body. # The path to the markdown file containing the comment body.