Make warnings require passing state #2
|
@ -91,7 +91,7 @@ with open(components_csv_path, newline="") as components_csv:
|
||||||
min_temp, max_temp = [int(x.strip("¡ãC ")) for x in row["Temperature"].split(" to ")]
|
min_temp, max_temp = [int(x.strip("¡ãC ")) for x in row["Temperature"].split(" to ")]
|
||||||
except ValueError:
|
except ValueError:
|
||||||
logger.warning(
|
logger.warning(
|
||||||
f"Designators(s) {row['Designator']} have malformed `Temperature` attribute: !"
|
f"Designators(s) {row['Designator']} have malformed `Temperature` attribute: {row['Temperature']}!"
|
||||||
)
|
)
|
||||||
component.warnings.append(f"Malformed `Temperature` attribute: `{row['Temperature']}`!")
|
component.warnings.append(f"Malformed `Temperature` attribute: `{row['Temperature']}`!")
|
||||||
else:
|
else:
|
||||||
|
|
|
@ -53,6 +53,7 @@ jobs:
|
||||||
run: .allspice/component_validation.py ./bom.csv
|
run: .allspice/component_validation.py ./bom.csv
|
||||||
|
|
||||||
- name: Post Comment on Design Review
|
- name: Post Comment on Design Review
|
||||||
|
if: always() # Generate the report even if the last step failed.
|
||||||
uses: https://hub.allspice.io/Actions/post-dr-comment@v0.1
|
uses: https://hub.allspice.io/Actions/post-dr-comment@v0.1
|
||||||
with:
|
with:
|
||||||
# The path to the markdown file containing the comment body.
|
# The path to the markdown file containing the comment body.
|
||||||
|
|
Loading…
Reference in New Issue