AllSpice-Demos/KiCAD-Demo
AllSpice-Demos/KiCAD-Demo
13
Fork 2
Files Issues 5 Design Reviews 1 Actions NEW Releases Activity

Minor fixes for V1.1 #2

Closed
allspice-hermes wants to merge 0 commits from develop into main
pull from: develop
merge into: AllSpice-Demos:main
Conversation 0 Commits - Files Changed - +53789 -32632
allspice-hermes commented 2024-07-12 18:18:06 +00:00
Owner
Copy Link

Resolved Issues

Closes #5

Description

Minor fixes to the PCB and Sch files. Added required capacitors, resistors and re-positioned some components for better distribution

Design Review Checklist

Process

  • Schematic and PCB file names follow standard
  • Export necessary review files (3D model, BOM, etc.)
  • Update relevant system architecture documents
  • Update project README page
  • Simulations uploaded and outputs explained

System

  • Power
    • Sufficient power supplied from upstream source
    • Supply rated for necessary country specifications
    • Estimated total worst-case power supply draw
  • Connectors
    • I/Os are specified
    • Sufficient Current and Voltage rating
    • Mating connectors have matching pinout
    • Same contact material specified for mating connectors
  • Testing
    • Test procedure written
  • Environmental
    • Specified min/max operating temperature
    • Specified min/max storage temperature
    • Specified min/max humidity
  • ROHS compliance requirement review

Components

  • Unpopulated components are denoted DNI
  • Components meet environmental specifications
  • All components have quantity, reference designator and description
  • Suggested and alternate manufacturers listed
  • Price and stock checked for each component
  • Component derating
    • Voltage
    • Current
    • Power at worst-case operating temperature
    • Temperature at worst-case power

Schematics

  • Document
    • Dot on each connection
    • No four-point connections
    • Title block completed for each sheet
    • All components have reference designators and values
    • Multi-part components don't have unplaced symbols
    • Page title present and consistent on all pages if not in title block
    • Symbols identify open collector/drain pins and internal pulled up/down pins
    • Pin names and attributes on symbols with multi-function pins should match actual design usage (I/O/Bi, Name)
    • Components follow preferred reference designator pattern

PCB

  • Manufacturing
    • PCB manufacturing requirements noted on fab layer
      • Plating specified
        • Plating material
        • Plating thickness
      • Layer stack-up specified
      • Minimum trace/space specified
      • Minimum hole size specified
      • PCB color specified
      • Silkscreen color specified
      • Controlled impedance specified
      • Blind or buried vias specified
      • Panelization specified
        • External routing specified (ex. v-groove vs route)
      • Drill table generated
      • All specifications exceed manufacturing tolerance
## Resolved Issues Closes #5 ## Description Minor fixes to the PCB and Sch files. Added required capacitors, resistors and re-positioned some components for better distribution ## Design Review Checklist ### Process - [ ] Schematic and PCB file names follow standard - [ ] Export necessary review files (3D model, BOM, etc.) - [ ] Update relevant system architecture documents - [ ] Update project README page - [ ] Simulations uploaded and outputs explained ### System - [ ] Power - [ ] Sufficient power supplied from upstream source - [ ] Supply rated for necessary country specifications - [ ] Estimated total worst-case power supply draw - [ ] Connectors - [ ] I/Os are specified - [ ] Sufficient Current and Voltage rating - [ ] Mating connectors have matching pinout - [ ] Same contact material specified for mating connectors - [ ] Testing - [ ] Test procedure written - [ ] Environmental - [ ] Specified min/max operating temperature - [ ] Specified min/max storage temperature - [ ] Specified min/max humidity - [ ] ROHS compliance requirement review ### Components - [ ] Unpopulated components are denoted DNI - [ ] Components meet environmental specifications - [ ] All components have quantity, reference designator and description - [ ] Suggested and alternate manufacturers listed - [ ] Price and stock checked for each component - [ ] Component derating - [ ] Voltage - [ ] Current - [ ] Power at worst-case operating temperature - [ ] Temperature at worst-case power ### Schematics - [ ] Document - [ ] Dot on each connection - [ ] No four-point connections - [ ] Title block completed for each sheet - [ ] All components have reference designators and values - [ ] Multi-part components don't have unplaced symbols - [ ] Page title present and consistent on all pages if not in title block - [ ] Symbols identify open collector/drain pins and internal pulled up/down pins - [ ] Pin names and attributes on symbols with multi-function pins should match actual design usage (I/O/Bi, Name) - [ ] Components follow preferred reference designator pattern <!-- Link to spec --> ### PCB - [ ] Manufacturing - [ ] PCB manufacturing requirements noted on `fab` layer - [ ] Plating specified - [ ] Plating material - [ ] Plating thickness - [ ] Layer stack-up specified - [ ] Minimum trace/space specified - [ ] Minimum hole size specified - [ ] PCB color specified - [ ] Silkscreen color specified - [ ] Controlled impedance specified - [ ] Blind or buried vias specified - [ ] Panelization specified - [ ] External routing specified (ex. v-groove vs route) - [ ] Drill table generated - [ ] All specifications exceed manufacturing tolerance
allspice-hermes added 1 commit 2024-07-12 18:18:06 +00:00
allspice-hermes added the
priority/3 - medium
layout
 labels 2024-07-12 18:51:24 +00:00
allspice-hermes self-assigned this 2024-07-12 18:51:28 +00:00
allspice-hermes requested review from RevaReviewa 2024-07-12 18:51:42 +00:00
allspice-hermes requested review from MikaChanical 2024-07-12 18:51:42 +00:00
allspice-hermes closed this pull request 2024-07-18 17:56:07 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
RevaReviewa
MikaChanical
Labels
Clear labels   
bug

Something doesn't work

  
dfm

Design for manufacturing consideration

  
documentation

Improvements to supporting documentation

  
eol

End of life component

  
feature

New feature or request

  
firmware

Requires FW attention

  
layout

Requires PCB layout attention

  
mechanical

Requires ME attention

  
priority/1 - idea

Nice to have or idea to capture

  
priority/2 - low

Should be resolved eventually

  
priority/3 - medium

Should be resolved before product launch

  
priority/4 - high

Should be resolved before next release

  
priority/5 - critical

Must be fixed immediately - blocking item

No Label
bug
dfm
documentation
eol
feature
firmware
layout
mechanical
priority/1 - idea
priority/2 - low
priority/3 - medium
priority/4 - high
priority/5 - critical
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
allspice-hermes
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AllSpice-Demos/KiCAD-Demo#2
No description provided.
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?