Sildeon

Sildeon commented

2019-12-16 01:47:04 +00:00

(Migrated from github.com)

Batch 1

issus commented

2019-12-19 09:36:45 +00:00

(Migrated from github.com)

SCH - BATTERY MGMT - ONSEMI LC709203FQH-01TWG.SCHLIB

Part ID should be 'ONSEMI LC709203FQH-01TWG' to match the file name.
Has extra 1 grid square of height at the top.
SCL/SDA should be together
ALARMB should be A\L\A\R\M\ for active low indication.
Test should be connected to VSS, so it should be grouped with the ground pins.

SCH - BATTERY MGMT - TI BQ27542DRZR-G1.SCHLIB

Part ID should be TI BQ27542DRZR-G1 to match the file name.
SCL should be above SDA - and they should be grouped together
I would have BAT on the right side above SRN/SRP as it's related to them.
REGIN and REG25 are for decoupling caps, its more convenient to have them down near GND
TS should probably be on the right side, as it's related to the battery?

SCH - CHARGER - LT BQ24074RGTR.SchLib

Looks like a TI part, not LT? File name should be SCH - CHARGER - TI BQ24074RGTR.SchLib
Part ID should be TI BQ24074RGTR
OUT should be top right, it's a power output
BAT should be top right, it's a charge output - I'd put it under OUT because it's likely going to need more space below it for the battery connections?
EN1/2 should be together, left side as they are setting pins
Pin numbering issues - the '74 package has pin 15 as ITERM not SYSOFF
CE should not be grouped with TMR - they don't provide similar/grouped functions

To be continued :)

**SCH - BATTERY MGMT - ONSEMI LC709203FQH-01TWG.SCHLIB** - Part ID should be 'ONSEMI LC709203FQH-01TWG' to match the file name. - Has extra 1 grid square of height at the top. - SCL/SDA should be together - ALARMB should be A\L\A\R\M\ for active low indication. - Test should be connected to VSS, so it should be grouped with the ground pins. **SCH - BATTERY MGMT - TI BQ27542DRZR-G1.SCHLIB** - Part ID should be TI BQ27542DRZR-G1 to match the file name. - SCL should be above SDA - and they should be grouped together - I would have BAT on the right side above SRN/SRP as it's related to them. - REGIN and REG25 are for decoupling caps, its more convenient to have them down near GND - TS should probably be on the right side, as it's related to the battery? **SCH - CHARGER - LT BQ24074RGTR.SchLib** - Looks like a TI part, not LT? File name should be SCH - CHARGER - TI BQ24074RGTR.SchLib - Part ID should be TI BQ24074RGTR - OUT should be top right, it's a power output - BAT should be top right, it's a charge output - I'd put it under OUT because it's likely going to need more space below it for the battery connections? - EN1/2 should be together, left side as they are setting pins - Pin numbering issues - the '74 package has pin 15 as ITERM not SYSOFF - CE should not be grouped with TMR - they don't provide similar/grouped functions To be continued :)

msamy0 commented

2020-10-29 13:45:48 +00:00

(Migrated from github.com)

SCH - BATTERY MGMT - ONSEMI LC709203FQH-01TWG.SCHLIB

@issus Notes.
Keep parameters empty as it is being filled later by the library tool.

SCH - BATTERY MGMT - TI BQ27542DRZR-G1.SCHLIB

Currently in the library.

SCH - CHARGER - LT BQ24074RGTR.SchLib

@issus Notes.
Rearrange pins

NEW ARRANGEMENT----------------------------------OLD ARRANGEMENT
..........................

Keep parameters empty as it is being filled later by the library tool.

SCH - OR CONTROLLER - LT LTC4357IMS8#PBF.SCHLIB

Item ID should be LT LTC4357IMS8#PBF
Designator = IC?
Comment = *
It is preferred to specify each pin electrical type (Passive, Power, Input, Output, ..etc.)
Keep parameters empty as it is being filled later by the library tool.

SCH - OR CONTROLLER - TI LM74610QDGKRQ1.SCHLIB

Not Connected (NC) Pins must not be represented in the SCH Lib
Rearrange pins according to ECAD guide.

SCH - OR CONTROLLER - TI TPS2113APWR.SCHLIB

Item ID
Designator
Comment
It is preferred to specify each pin electrical type (Passive, Power, Input, Output, ..etc.)
Keep parameters empty as it is being filled later by the library tool.
Rearrange pins according to ECAD guide.

SCH - SENSOR - CURRENT - TI INA168NA-3K.SCHLIB

Exactly the same comments as previous one.

SCH - SENSOR - CURRENT - TI INA168NA-3K.SCHLIB

Exactly the same comments as previous one.

SCH - SENSOR - CURRENT - TI INA193AIDBVR.SCHLIB

Exactly the same comments as previous one.

RES YAGEO RC0100_01005.STEP

Currently in the Lib name according to Metric method as RES - 0402.step.

RES MURATA GRM02_01005.STEP

Currently this package is in the Library. It is named as CAP 01005.step.

PCB - RESISTOR - CHIP - YAGEO 01005.PcbLib

Currently in the Library.

PCB - RESISTOR - CHIP - MURATA GRM02_01005.PcbLib

Currently in the Library.

TI UQFN-10 RSE.STEP

Pin1 mark is too deep and large.
Model must contain one body
leads dimensions is not fixed for all the 10 leads, so make sire to stick to the datasheet dimensions.

PCB - LEADLESS - QFN - TI UQFN-10 RSE.PcbLib

Please refer to ECAD guide. for layers and tolerances.
Mechanical 11 layer is not needed
mechanical 15 layer is used to create a rectangular which encapsulate the footprint with offset 0.2mm from any outer point with track thickness of 0.05mm.
Pads dimensions needs rework.
Mechanical 13 is is used to outline the package with track thickness of 0.1mm.
3D Model is added to Mechanical 1.

**SCH - BATTERY MGMT - ONSEMI LC709203FQH-01TWG.SCHLIB** - @issus Notes. - Keep parameters empty as it is being filled later by the library tool. **SCH - BATTERY MGMT - TI BQ27542DRZR-G1.SCHLIB** - Currently in the library. **SCH - CHARGER - LT BQ24074RGTR.SchLib** - @issus Notes. - Rearrange pins NEW ARRANGEMENT----------------------------------OLD ARRANGEMENT <img src="https://user-images.githubusercontent.com/64434690/97564081-aff55800-19ec-11eb-8489-a5e0a799d8dd.png" width="240" /> ..........................<img src="https://user-images.githubusercontent.com/64434690/97564110-c00d3780-19ec-11eb-9dfa-d9f820048223.png" width="200" /> - Keep parameters empty as it is being filled later by the library tool. **SCH - OR CONTROLLER - LT LTC4357IMS8#PBF.SCHLIB** - Item ID should be LT LTC4357IMS8#PBF - Designator = IC? - Comment = * - It is preferred to specify each pin electrical type (Passive, Power, Input, Output, ..etc.) - Keep parameters empty as it is being filled later by the library tool. **SCH - OR CONTROLLER - TI LM74610QDGKRQ1.SCHLIB** - Not Connected (NC) Pins must not be represented in the SCH Lib - Rearrange pins according to [ECAD](https://docs.google.com/document/d/1ZrxRc5H29G4eTV5gg6057-foMoErHGoD3JRgLENd1BE/edit#) guide. **SCH - OR CONTROLLER - TI TPS2113APWR.SCHLIB** - Item ID - Designator - Comment - It is preferred to specify each pin electrical type (Passive, Power, Input, Output, ..etc.) - Keep parameters empty as it is being filled later by the library tool. - Rearrange pins according to [ECAD](https://docs.google.com/document/d/1ZrxRc5H29G4eTV5gg6057-foMoErHGoD3JRgLENd1BE/edit#) guide. **SCH - SENSOR - CURRENT - TI INA168NA-3K.SCHLIB** - Exactly the same comments as previous one. **SCH - SENSOR - CURRENT - TI INA168NA-3K.SCHLIB** - Exactly the same comments as previous one. **SCH - SENSOR - CURRENT - TI INA193AIDBVR.SCHLIB** - Exactly the same comments as previous one. **RES YAGEO RC0100_01005.STEP** - Currently in the Lib name according to Metric method as _RES - 0402.step_. **RES MURATA GRM02_01005.STEP** - Currently this package is in the Library. It is named as _CAP 01005.step_. **PCB - RESISTOR - CHIP - YAGEO 01005.PcbLib** - Currently in the Library. **PCB - RESISTOR - CHIP - MURATA GRM02_01005.PcbLib** - Currently in the Library. **TI UQFN-10 RSE.STEP** - Pin1 mark is too deep and large. - Model must contain one body - leads dimensions is not fixed for all the 10 leads, so make sire to stick to the [datasheet](https://www.ti.com/lit/ml/mpqf186d/mpqf186d.pdf?ts=1603977364767&ref_url=https%253A%252F%252Fwww.ti.com%252Fpackaging%252Fdocs%252Fsearchtipackages.tsp%253FpackageName%253DQFN) dimensions. **PCB - LEADLESS - QFN - TI UQFN-10 RSE.PcbLib** - Please refer to [ECAD](https://docs.google.com/document/d/1ZrxRc5H29G4eTV5gg6057-foMoErHGoD3JRgLENd1BE/edit#) guide. for layers and tolerances. - Mechanical 11 layer is not needed - mechanical 15 layer is used to create a rectangular which encapsulate the footprint with offset 0.2mm from any outer point with track thickness of 0.05mm. - Pads dimensions needs rework. - Mechanical 13 is is used to outline the package with track thickness of 0.1mm. - 3D Model is added to Mechanical 1.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b Sildeon/Sildeon master

git pull origin Sildeon/Sildeon

Step 2:

Merge the changes and update on AllSpice.

git checkout master

git merge --no-ff Sildeon/Sildeon

git push origin master

Sildeon #43

Step 1:

Step 2: