AllSpice-demos
/
Altium-Celestial-library
12
Fork 0
Files Issues 16 Design Reviews 8 Releases Activity

Changed footprint to 8 pin version. #82

Open
ing-kuczmik wants to merge 2 commits from ing-kuczmik/bug_JST_SM08B into master
pull from: ing-kuczmik/bug_JST_SM08B
merge into: AllSpice-demos:master
Conversation 3 Commits 2 Files Changed 2
ing-kuczmik commented 2020-11-03 10:47:16 +00:00 (Migrated from github.com)
Copy Link

As described in Issue: JST Connector SM08B-SURS-TF(LF)(SN) #81

As described in Issue: JST Connector SM08B-SURS-TF(LF)(SN) #81
msamy0 commented 2020-11-18 02:48:59 +00:00 (Migrated from github.com)
Copy Link

Thanks for your contribution
I know you have just edited the premade 7-pins foot print and extended it to a 8-Pins one, however another edits is required

  • Mech.15 outer lines should be 0.05mm width
  • Mech.15 origin + mark should be in 0.1 line width
  • 3D model should lay in the Mech.1 Layer
  • Mech.13 layer should have a contour around the 3d model projection like this
    image
Thanks for your contribution I know you have just edited the premade 7-pins foot print and extended it to a 8-Pins one, however another edits is required - Mech.15 outer lines should be 0.05mm width - Mech.15 origin + mark should be in 0.1 line width - 3D model should lay in the Mech.1 Layer - Mech.13 layer should have a contour around the 3d model projection like this ![image](https://user-images.githubusercontent.com/64434690/99476489-4f0cd000-2959-11eb-8c3f-53726c8bc862.png)
ing-kuczmik commented 2020-11-18 08:32:48 +00:00 (Migrated from github.com)
Copy Link

Hey, i correct the footprint to the celestial rules. Because I first grap the wrong footprint the BM08B Version is also corrected.

Hey, i correct the footprint to the celestial rules. Because I first grap the wrong footprint the BM08B Version is also corrected.
msamy0 commented 2020-11-18 09:29:01 +00:00 (Migrated from github.com)
Copy Link

Okay, nice !
both will be merged soon, thanks !

Okay, nice ! both will be merged soon, **thanks** !
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b ing-kuczmik/bug_JST_SM08B master
git pull origin ing-kuczmik/bug_JST_SM08B

Step 2:

Merge the changes and update on AllSpice.
git checkout master
git merge --no-ff ing-kuczmik/bug_JST_SM08B
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AllSpice-demos/Altium-Celestial-library#82
No description provided.
Delete Branch "ing-kuczmik/bug_JST_SM08B"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?