You've already forked torvalds-GuitarPedal
mirror of
https://github.com/torvalds/GuitarPedal.git
synced 2026-09-11 17:10:09 +00:00
b5fe6b10b8
Pre-FX adds the host's audio to whatever the jack is doing, which is what you want when playing along with a backing track and is a trap when measuring: whatever is plugged in becomes part of the answer, and an open jack's noise is a floor that a null test cannot get below. Replace ignores the jack, so what comes out is a function of what the host sent and nothing else - which is what makes a digital end-to-end path through the pedal, stimulus and capture both over USB, and a measurement that is about the effect rather than about the room. Appended to the enum rather than slotted in beside Pre-FX where it belongs, because the value is stored in a scene and the enum's order is what it is stored as. Putting Replace second would silently turn every saved Mix into a Replace, and the scene checksum is a plain sum, so it cannot tell a reordering from the values it was given. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>