You've already forked torvalds-GuitarPedal
mirror of
https://github.com/torvalds/GuitarPedal.git
synced 2026-08-18 13:13:35 +00:00
'Software' was the directory everything that was not KiCad ended up in, which stopped describing anything a while ago - Validation and the web app are software too. Worse, it put the shared parts inside the firmware, where they read as the firmware's own. They are not. Effects/ has three consumers built from it: the firmware, Validation's bench, and the web app's controls, all generated from the same POT: comments by gen_effects.py. Audio/ has two - the bench compiles the same biquads, the same envelope followers and the same single_sample(), which is the whole reason a measurement on a workstation says anything about the pedal. Neither belongs under Firmware/, so neither is under it any more: Effects/ one file per effect Audio/ the DSP they are built from, and the audio loop Firmware/ the rest of what runs on the pedal, and the submodules WebMIDI/ the web app scripts/ what the build runs Validation/ unchanged Hardware/, Documentation/, Images/ CMakeLists.txt and the wrapper Makefile move to the top with them, because the build now consumes four of those directories and generates into a fifth. board.local and build/ come along; MIDI_CC_MAP.md is generated into Documentation/ rather than into the old Software/ root. scripts/ goes with the build rather than staying under the firmware, because six of the ten had nothing to do with the firmware: gen_effects.py reads Effects/ and writes to three different places, pow2/log2/quarter_sine generate Audio/'s tables, check-readme.py compares Effects/ against the README, and server.py serves the web app. Four of them are invoked from Validation, which was reaching into Firmware/ for tooling - the same burying this commit is undoing. The four that really are about the firmware are ELF checks the top-level build drives anyway, and a second scripts directory would only be a second place to look. C includes say "Audio/foo.h" and the generated map says "Effects/bar.h", with the repository root on the include path for both the firmware and the bench. Spelling the directory out rather than relying on a bare name is what keeps Audio/cycles.h shimmable: a quoted include searches the including file's own directory first. The submodules are renamed as well as moved. git mv updates their paths but leaves the section names, and 'Software/pico-sdk' surviving in .gitmodules would be the word this commit removes, still load-bearing. That meant the nested modules under pico-sdk too - six .git files pointing into .git/modules/Software - which is why 'git submodule update --init --recursive' is worth running once after pulling this. Verified rather than assumed: a clean configure and build, make check (failing only on the missing-eeprom case it already failed on), check-effects, all four analysis pages reproducing every series and drawing every chart, and a flash to the board that still measures a routed reverb where it did before. One latent bug fell out of it. bench/coeff declared only quarter_sine.h of the three generated math tables, and Audio/util.h includes pow2.h and log2.h as well - so building that target with an empty gen/ could never have worked. 'make bench' builds bench/bench first, which generates all three, so it stayed hidden until this rebuilt everything from nothing. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
191 lines
6.1 KiB
C
191 lines
6.1 KiB
C
//
|
|
// Our LFO generates a quarter cycle (0 .. 1) from a 30-bit cycle
|
|
// and when it overflows it changes the quarter counter, which
|
|
// then turns 0..1 into a series of [ 0..1 , 1..0 , 0..-1, -1..0 ]
|
|
//
|
|
// The quarter information is naturally in the two high
|
|
// bits of the index
|
|
//
|
|
// Every audio cycle we update the LFO counter by 'lfo_step',
|
|
// so the cycle of one quarter is
|
|
//
|
|
// t = 2**30 / SAMPLES_PER_SEC / lfo_step
|
|
//
|
|
// and a full cycle is four times that (ie the full 32-bit cycle).
|
|
//
|
|
// Calling that (2**32)/SAMPLES_PER_SEC "F_STEP", we get
|
|
//
|
|
// T = F_STEP / lfo_step
|
|
// freq = lfo_step / F_STEP
|
|
// => lfo_step = freq * F_STEP
|
|
// ms = 1000 * T = 1000 * F_STEP / lfo_step
|
|
// => lfo_step = 1000 * F_STEP / ms
|
|
//
|
|
#define F_STEP (TWO_POW_32/SAMPLES_PER_SEC)
|
|
|
|
//
|
|
// THE THREE SHAPES DO NOT SHARE A RANGE. Sine and triangle are bipolar,
|
|
// -1 to 1, because that is what a modulator added to a centre value
|
|
// wants. The sawtooth is 0 to 1, and that is deliberate: it is the raw
|
|
// phase, so it can be handed straight to something that takes a phase in
|
|
// cycles. tremolo.h feeds it to fastsincos() and gets its rotation for
|
|
// free, with no scaling in between and no wrap to get wrong.
|
|
//
|
|
// The asymmetry earns its keep, so it stays - but it is worth what it
|
|
// costs only if it is known about, and it was not written down anywhere
|
|
// until a test tone read the shape number straight out of this enum and
|
|
// produced a saw with half its level in DC. An audio waveform wants
|
|
// 2*v - 1; a phase does not. Ask which one you are asking for.
|
|
//
|
|
enum lfo_type {
|
|
lfo_sinewave, // -1 .. 1
|
|
lfo_triangle, // -1 .. 1
|
|
lfo_sawtooth, // 0 .. 1 - raw phase, see above
|
|
};
|
|
|
|
struct lfo_state {
|
|
u32 idx, step;
|
|
};
|
|
|
|
// Use this for LFO initializers.
|
|
#define LFO_FREQ(x) .step = (x)*F_STEP
|
|
|
|
static inline void set_lfo_step(struct lfo_state *lfo, float step)
|
|
{
|
|
lfo->step = (u32) rintf(step);
|
|
}
|
|
|
|
void set_lfo_freq(struct lfo_state *lfo, float freq)
|
|
{
|
|
set_lfo_step(lfo, freq * F_STEP);
|
|
}
|
|
|
|
void set_lfo_ms(struct lfo_state *lfo, float ms)
|
|
{
|
|
// Max 10kHz
|
|
if (ms < 0.1)
|
|
ms = 0.1;
|
|
set_lfo_step(lfo, 1000 * F_STEP / ms);
|
|
}
|
|
|
|
//
|
|
// Marked, rather than trusting it to inline. It always had, because
|
|
// every effect called it exactly once - and the first one to call it
|
|
// twice turned it into a real call and a veneer out of the audio
|
|
// sections, which check-audio.py then refused.
|
|
//
|
|
float __audio_func(lfo_step)(struct lfo_state *lfo, enum lfo_type type)
|
|
{
|
|
u32 now = lfo->idx;
|
|
u32 next = now + lfo->step;
|
|
|
|
lfo->idx = next;
|
|
|
|
if (type == lfo_sawtooth)
|
|
return u32_to_fraction(now);
|
|
|
|
float val;
|
|
u32 quarter = now >> 30;
|
|
now <<= 2;
|
|
|
|
// Second and fourth quarter reverses direction
|
|
if (quarter & 1)
|
|
now = ~now;
|
|
|
|
if (type == lfo_sinewave) {
|
|
u32 idx = now >> (32-QUARTER_SINE_STEP_SHIFT);
|
|
float a = quarter_sin[idx];
|
|
float b = quarter_sin[idx+1];
|
|
|
|
now <<= QUARTER_SINE_STEP_SHIFT;
|
|
val = a + (b-a)*u32_to_fraction(now);
|
|
} else {
|
|
val = u32_to_fraction(now);
|
|
}
|
|
|
|
// Last two quarters are negative
|
|
if (quarter & 2)
|
|
val = -val;
|
|
return val;
|
|
}
|
|
|
|
//
|
|
// SLOW LFOs, WHICH ARE MOST OF THEM
|
|
//
|
|
// Running the quarter-sine lookup 48000 times a second to describe
|
|
// something whose period is a couple of seconds is silly, and it is
|
|
// measurably expensive: on the RP2354 the reverb's four LFOs cost about
|
|
// 11% of the whole effect. That expense is exactly why the reverb
|
|
// arrived here carrying its own hand-rolled rotator instead, which then
|
|
// spent thirteen hours walking out of its buffer.
|
|
//
|
|
// So: do the real thing every LFO_X samples, and walk a straight line
|
|
// between those points. The error is the sagitta of a sine over the
|
|
// span and grows as LFO_X squared - at 32 it is 120dB down for the
|
|
// reverb's 0.67Hz, 73dB down at a 10Hz tremolo and 49dB down for the
|
|
// fastest thing here, a 40Hz phaser.
|
|
//
|
|
// WHY 32, AND WHY IT IS NOT A PARAMETER
|
|
//
|
|
// Per-sample work is one add plus 1/X of the real computation, so the
|
|
// cost falls towards the cost of that one add and then stops. 32 is
|
|
// already there: measured on hardware, X=256 came out 0.64 telemetry
|
|
// steps cheaper than X=32, which is inside the noise, while costing
|
|
// 36dB of accuracy. Past the knee, so a knob for it would only be a
|
|
// way to get it wrong.
|
|
//
|
|
// WHICH LFOs THIS IS NOT FOR
|
|
//
|
|
// testtone.h drives lfo_step() up to 14kHz on purpose - the shapes are
|
|
// the LFO's, at audio rate, and set_lfo_freq() is deliberately
|
|
// unclamped. Chording that would be nonsense. Hence a separate call
|
|
// rather than a change to lfo_step(): the fast path stays exact and
|
|
// asking for the cheap one is a decision at the call site.
|
|
//
|
|
// THE COUNTER IS THE CHAIN'S, NOT THE EFFECT'S
|
|
//
|
|
// single_sample() increments this once a frame and nothing else touches
|
|
// it. Having one counter rather than one per LFO is what lets the
|
|
// compiler see that four lfo_step_X() calls in a row share a test, and
|
|
// it means an effect cannot get its own phase wrong. It is allowed to
|
|
// wrap; only the low bits are ever read.
|
|
//
|
|
unsigned audio_sample_count;
|
|
|
|
#define LFO_X_BITS 5
|
|
#define LFO_X (1u << LFO_X_BITS)
|
|
#define LFO_X_MASK (LFO_X - 1)
|
|
|
|
struct lfo_slow {
|
|
struct lfo_state lfo;
|
|
float value, slope;
|
|
};
|
|
|
|
//
|
|
// The step is LFO_X times bigger because it is applied LFO_X times less
|
|
// often. Same accumulator, same wrap, same everything else.
|
|
//
|
|
static inline void set_lfo_freq_X(struct lfo_slow *s, float freq)
|
|
{
|
|
set_lfo_step(&s->lfo, freq * F_STEP * LFO_X);
|
|
}
|
|
|
|
//
|
|
// A new frequency takes effect at the next recalculation rather than at
|
|
// once, which is a property of the model rather than a wart in it: the
|
|
// value is mid-chord and the chord it is on was costed before the knob
|
|
// moved. Worst case is LFO_X samples of the old rate, which is 667us.
|
|
//
|
|
// Nothing is seeded here or at init. value and slope start at zero, so
|
|
// the first block walks from zero up to wherever the LFO actually is -
|
|
// a 667us fade in on a modulator, which is not worth code to avoid.
|
|
//
|
|
static inline float lfo_step_X(struct lfo_slow *s, enum lfo_type type)
|
|
{
|
|
if (!(audio_sample_count & LFO_X_MASK)) {
|
|
float next = lfo_step(&s->lfo, type);
|
|
s->slope = (next - s->value) * (1.0f / LFO_X);
|
|
}
|
|
return (s->value += s->slope);
|
|
}
|