AllSpice-Demos/Altium-Demo
AllSpice-Demos
/
Altium-Demo
12
Fork 1
Files Issues 7 Design Reviews 1 Actions NEW Releases 2 Activity

Add ESD Protection to Endstops #2

Open
AllSpiceAlice wants to merge 5 commits from develop into main
pull from: develop
merge into: AllSpice-Demos:main
Conversation 1 Commits 5 Files Changed 4
1 changed files with 0 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 67663ce7a4 - Show all commits

Archimajor.PcbDoc
View File

LOADING
brendan marked this conversation as resolved
RevaReviewa commented 2024-07-28 23:27:03 +00:00
Review
Copy Link

@daniel, why did we remove the debug header?

!thumbnail[](Archimajor.PcbDoc){ diff="AllSpice-Demos/Altium-Demo:c285374952fcea88c33ee99a6badbfa58c18cc50...7eaa84ee12e13afc3adee15ebf0e4f30f55007c4" pr="2" layers="82,81,74,72,71,69,68,66,65,64,63,62,60,59,58,57,33,35,37,1,41,40,2,39,32,38,34" diff-visibility="full" variant="default" view-coords="17.9,3.2,33.8,21.9" aspect-ratio="1.347" } @daniel, why did we remove the debug header?
daniel commented 2024-07-28 23:28:05 +00:00
Review
Copy Link

It's the same connector as one of the fan drivers, so technicians and end-users were accidentally pluging in debug equipment into the fan drivers and vice-versa. This was to make it accident-proof.

It's the same connector as one of the fan drivers, so technicians and end-users were accidentally pluging in debug equipment into the fan drivers and vice-versa. This was to make it accident-proof.
RevaReviewa commented 2024-07-28 23:28:39 +00:00
Review
Copy Link

That makes sense, thank you.

That makes sense, thank you.
brendan marked this conversation as resolved
daniel commented 2024-07-28 23:30:24 +00:00
Review
Copy Link

@AllSpiceAlice , can you have someone on your team review the new 5V power trace thickness?

!thumbnail[](Archimajor.PcbDoc){ diff="AllSpice-Demos/Altium-Demo:c285374952fcea88c33ee99a6badbfa58c18cc50...7eaa84ee12e13afc3adee15ebf0e4f30f55007c4" pr="2" layers="82,81,74,72,71,69,68,66,65,64,63,62,60,59,58,57,33,35,37,1,41,40,2,39,32,38,34" diff-visibility="full" variant="default" view-coords="62.1,11.7,82.9,34.8" aspect-ratio="1.347" } @AllSpiceAlice , can you have someone on your team review the new 5V power trace thickness?
AllSpiceAlice commented 2024-07-28 23:31:52 +00:00
Review
Copy Link

Thank you @daniel, this looks great. All the changes were so quick. Thank you for the expedited layout changes! 🚀

Thank you @daniel, this looks great. All the changes were so quick. Thank you for the expedited layout changes! 🚀
MikaChanical commented 2024-07-28 23:42:06 +00:00
Review
Copy Link

@AllSpiceAlice, new mounting holes are perfect. 🥇

!thumbnail[](Archimajor.PcbDoc){ diff="AllSpice-Demos/Altium-Demo:c285374952fcea88c33ee99a6badbfa58c18cc50...7eaa84ee12e13afc3adee15ebf0e4f30f55007c4" pr="2" layers="82,81,74,72,71,69,68,66,65,64,63,62,60,59,58,57,33,35,37,1,41,40,2,39,32,38,34" diff-visibility="full" variant="default" view-coords="53.0,0.4,64.8,15.4" aspect-ratio="1.347" } @AllSpiceAlice, new mounting holes are perfect. 🥇
allspice-hermes commented 2024-10-04 17:42:15 +00:00
Review
Copy Link

Can we make sure that they have the right measures? I thought they were smaller @AllSpiceAlice @MikaChanical

Can we make sure that they have the right measures? I thought they were smaller @AllSpiceAlice @MikaChanical