Add ESD Protection to Endstops #2

Open

AllSpiceAlice wants to merge 5 commits from develop into main

pull from: develop

merge into: AllSpice-Demos:main

AllSpice-Demos/{11258 819 AllSpice-Demos 0xc002f36b40 altium-demo Altium-Demo Altium Demo Archimajor 3D Printer Controller PCB 0 main 11 0 0 8 3 5 2 1 1 1 0 1 0 0 0 46 46 0 false false false false 0 map[mode:comment org:allspice-demos repo:Altium-Demo repoPath:/var/lib/gitea/git/repositories/allspice-demos/altium-demo.git teams:,contributors,owners, user:AllSpice-Demos] map[] [0xc00344e090 0xc00344e210 0xc00344e570 0xc00344ebd0 0xc00344ef00] <nil> false 0 <nil> false 0 305881697 305881697 0 <nil> <nil> true false [] default c3d6a10a180529704d48f585e3b156a75208633eb48476e04ca0064df32d062c 1722206549 1726759705 0}:main

Conversation 1 Commits 5 Files Changed 4

1 changed files with 0 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files Show outdated comments

Showing only changes of commit 7eaa84ee12 - Show all commits

Archimajor.PcbDoc

View File

LOADING

RevaReviewa commented 2024-07-28 23:27:03 +00:00

Review

Copy Link

@daniel, why did we remove the debug header?

!thumbnail[](Archimajor.PcbDoc){ diff="AllSpice-Demos/Altium-Demo:c285374952fcea88c33ee99a6badbfa58c18cc50...7eaa84ee12e13afc3adee15ebf0e4f30f55007c4" pr="2" layers="82,81,74,72,71,69,68,66,65,64,63,62,60,59,58,57,33,35,37,1,41,40,2,39,32,38,34" diff-visibility="full" variant="default" view-coords="17.9,3.2,33.8,21.9" aspect-ratio="1.347" } @daniel, why did we remove the debug header?

daniel commented 2024-07-28 23:28:05 +00:00

Review

Copy Link

It's the same connector as one of the fan drivers, so technicians and end-users were accidentally pluging in debug equipment into the fan drivers and vice-versa. This was to make it accident-proof.

It's the same connector as one of the fan drivers, so technicians and end-users were accidentally pluging in debug equipment into the fan drivers and vice-versa. This was to make it accident-proof.

RevaReviewa commented 2024-07-28 23:28:39 +00:00

Review

Copy Link

That makes sense, thank you.

That makes sense, thank you.

Previous Next

daniel commented 2024-07-28 23:30:24 +00:00

Review

Copy Link

@AllSpiceAlice , can you have someone on your team review the new 5V power trace thickness?

!thumbnail[](Archimajor.PcbDoc){ diff="AllSpice-Demos/Altium-Demo:c285374952fcea88c33ee99a6badbfa58c18cc50...7eaa84ee12e13afc3adee15ebf0e4f30f55007c4" pr="2" layers="82,81,74,72,71,69,68,66,65,64,63,62,60,59,58,57,33,35,37,1,41,40,2,39,32,38,34" diff-visibility="full" variant="default" view-coords="62.1,11.7,82.9,34.8" aspect-ratio="1.347" } @AllSpiceAlice , can you have someone on your team review the new 5V power trace thickness?

AllSpiceAlice commented 2024-07-28 23:31:52 +00:00

Review

Copy Link

Thank you @daniel, this looks great. All the changes were so quick. Thank you for the expedited layout changes! 🚀

Thank you @daniel, this looks great. All the changes were so quick. Thank you for the expedited layout changes! 🚀

Previous Next

MikaChanical commented 2024-07-28 23:42:06 +00:00

Review

Copy Link

@AllSpiceAlice, new mounting holes are perfect. 🥇

!thumbnail[](Archimajor.PcbDoc){ diff="AllSpice-Demos/Altium-Demo:c285374952fcea88c33ee99a6badbfa58c18cc50...7eaa84ee12e13afc3adee15ebf0e4f30f55007c4" pr="2" layers="82,81,74,72,71,69,68,66,65,64,63,62,60,59,58,57,33,35,37,1,41,40,2,39,32,38,34" diff-visibility="full" variant="default" view-coords="53.0,0.4,64.8,15.4" aspect-ratio="1.347" } @AllSpiceAlice, new mounting holes are perfect. 🥇

Previous Next