AllSpice-Demos/KiCAD-Demo
AllSpice-Demos/KiCAD-Demo
13
Fork 2
Files Issues 5 Design Reviews 1 Actions NEW Releases 1 Activity

Bug Fixes and component re-positioning #8

Open
allspice-hermes wants to merge 10 commits from develop into main
pull from: develop
merge into: AllSpice-Demos:main
Conversation 0 Commits 10 Files Changed 5 +746 -328
1 changed files with 746 additions and 328 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 02cade736c - Show all commits

VREG_5V_3.3V.kicad_sch
View File

LOADING
RevaReviewa commented 2024-10-17 03:28:06 +00:00
Review
Copy Link

@AllSpiceAlice, can we disconnect SCK from this buffer? We're getting interference.

!thumbnail[](VREG_5V_3.3V.kicad_sch){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...f0c6d1baba28db424093a9ac75be40fd55c2c518" pr="8" doc-id="3c86f159e194b13ca2d9" diff-visibility="full" variant="default" view-coords="5.4,45.6,33.0,67.0" aspect-ratio="1.405" } @AllSpiceAlice, can we disconnect SCK from this buffer? We're getting interference.
AllSpiceAlice commented 2024-10-17 03:29:08 +00:00
Review
Copy Link

@RevaReviewa , Removed

!thumbnail[](VREG_5V_3.3V.kicad_sch){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...a3c822e27c2b431d95cff1fd8b9d166fa3007c5e" pr="8" doc-id="3c86f159e194b13ca2d9" diff-visibility="full" variant="default" view-coords="5.2,43.3,34.5,65.2" aspect-ratio="1.405" } @RevaReviewa , Removed
RevaReviewa commented 2024-10-17 03:30:15 +00:00
Review
Copy Link

@AllSpiceAlice did you park the comparator? You need to check the datasheet to see if you need to pull up/down the inputs/outputs when not in use?

@AllSpiceAlice did you park the comparator? You need to check the datasheet to see if you need to pull up/down the inputs/outputs when not in use?
AllSpiceAlice commented 2024-10-17 03:30:43 +00:00
Review
Copy Link

@RevaReviewa I did not! Thank you for spotting that!

@RevaReviewa I did not! Thank you for spotting that!