AllSpice-Demos/KiCAD-Demo
AllSpice-Demos/KiCAD-Demo
13
Fork 2
Files Issues 5 Design Reviews 1 Actions NEW Releases 1 Activity

Bug Fixes and component re-positioning #8

Open
allspice-hermes wants to merge 10 commits from develop into main
pull from: develop
merge into: AllSpice-Demos:main
Conversation 0 Commits 10 Files Changed 5 +53550 -32632
5 changed files with 53550 additions and 32632 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f0c6d1baba - Show all commits

Bootloader-ATMEGA16U.kicad_sch
View File

LOADING
PavelInPurchasing commented 2024-10-17 02:58:03 +00:00
Review
Copy Link

@daniel , can you remove this connector? It's EOL, and the team agreed they didn't need it anyways.

!thumbnail[](Bootloader-ATMEGA16U.kicad_sch){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...5fd194e5655270f77442cdb95cbbe5606af50380" pr="8" doc-id="2318a9d9d4f9a5612643" diff-visibility="full" variant="default" view-coords="65.4,27.2,73.8,39.0" aspect-ratio="1.405" } @daniel , can you remove this connector? It's EOL, and the team agreed they didn't need it anyways.
daniel-allspice commented 2024-10-17 03:01:10 +00:00
Review
Copy Link

@PavelInPurchasing, it's been removed

@PavelInPurchasing, it's been removed !thumbnail[](Bootloader-ATMEGA16U.kicad_sch){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...4d8a762fe08925f5f8fa254d91605e36e96f5fe3" pr="8" doc-id="2318a9d9d4f9a5612643" diff-visibility="full" variant="default" view-coords="48.8,29.9,67.2,39.4" aspect-ratio="1.405" }
RevaReviewa commented 2024-10-17 03:05:34 +00:00
Review
Copy Link

@AllSpiceAlice, can you add another reset switch to GND for RESET2?

!thumbnail[](Bootloader-ATMEGA16U.kicad_sch){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...5fd194e5655270f77442cdb95cbbe5606af50380" pr="8" doc-id="2318a9d9d4f9a5612643" diff-visibility="full" variant="default" view-coords="31.7,23.7,43.2,29.5" aspect-ratio="1.405" } @AllSpiceAlice, can you add another reset switch to GND for RESET2?
AllSpiceAlice commented 2024-10-17 03:07:21 +00:00
Review
Copy Link

@RevaReviewa , here you go! That should help the manufacturing team figure out the programming sequence without worrying about bricking the microcontrollers or the bootloader.

!thumbnail[](Bootloader-ATMEGA16U.kicad_sch){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...4d8a762fe08925f5f8fa254d91605e36e96f5fe3" pr="8" doc-id="2318a9d9d4f9a5612643" diff-visibility="full" variant="default" view-coords="15.7,14.2,43.2,34.8" aspect-ratio="1.405" } @RevaReviewa , here you go! That should help the manufacturing team figure out the programming sequence without worrying about bricking the microcontrollers or the bootloader.

SingleBoardComputer.kicad_pcb
View File

LOADING
brendan marked this conversation as resolved Outdated
brendan commented 2024-09-18 17:29:31 +00:00
Outdated
Review
Copy Link

@gautam Please review

!thumbnail[](SingleBoardComputer.kicad_pcb){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...f0c6d1baba28db424093a9ac75be40fd55c2c518" pr="8" layers="1" diff-visibility="full" variant="default" view-coords="75.0,29.9,86.1,45.4" aspect-ratio="0.994" } @gautam Please review
👍 1
AllSpiceAlice commented 2024-10-17 01:44:28 +00:00
Outdated
Review
Copy Link

Please check the vias underneath U100 @daniel

Please check the vias underneath U100 @daniel !thumbnail[](SingleBoardComputer.kicad_pcb){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...f0c6d1baba28db424093a9ac75be40fd55c2c518" pr="8" layers="82,81,63,61,60,59,58,57,33,35,37,1,32,38,34" diff-visibility="full" variant="default" view-coords="42.8,42.4,57.1,56.2" aspect-ratio="0.994" }
MikaChanical commented 2024-10-17 01:50:41 +00:00
Outdated
Review
Copy Link

@AllSpiceAlice , can you update the silkscreen on this footprint. It's unclear where to place it.

!thumbnail[](SingleBoardComputer.kicad_pcb){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...f0c6d1baba28db424093a9ac75be40fd55c2c518" pr="8" layers="82,81,63,61,60,59,58,57,33,35,37,1,32,38,34" diff-visibility="full" variant="default" view-coords="31.7,21.8,82.2,28.9" aspect-ratio="0.994" } @AllSpiceAlice , can you update the silkscreen on this footprint. It's unclear where to place it.
AllSpiceAlice commented 2024-10-17 03:15:45 +00:00
Outdated
Review
Copy Link

@MikaChanical , how does J3 look? If you like it, I'll fix the other connector.

!thumbnail[](SingleBoardComputer.kicad_pcb){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...1ad1cc6d8062201c0f3e9d2e8271c5c6b78b37fe" pr="8" layers="82,81,63,61,60,59,58,57,33,35,37,1,32,38,34" diff-visibility="full" variant="default" view-coords="32.9,22.3,61.2,27.1" aspect-ratio="0.994" } @MikaChanical , how does J3 look? If you like it, I'll fix the other connector.
MikaChanical commented 2024-10-17 03:18:20 +00:00
Outdated
Review
Copy Link

@AllSpiceAlice, would you make both the Pin-1 triangle and circle markers bigger. There are models with polarized retention features, so we need this to be big enough for fab.

@AllSpiceAlice, would you make both the Pin-1 triangle and circle markers bigger. There are models with polarized retention features, so we need this to be big enough for fab.
AllSpiceAlice commented 2024-10-17 03:23:15 +00:00
Outdated
Review
Copy Link

@MikaChanical , how do these look? I removed the triangle to cut down on visual clutter.

!thumbnail[](SingleBoardComputer.kicad_pcb){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...a3c822e27c2b431d95cff1fd8b9d166fa3007c5e" pr="8" layers="82,81,63,61,60,59,58,57,33,35,37,1,32,38,34" diff-visibility="full" variant="default" view-coords="28.8,21.6,85.1,30.1" aspect-ratio="0.994" } @MikaChanical , how do these look? I removed the triangle to cut down on visual clutter.

9
SingleBoardComputer.kicad_pro generated
View File

@ -59,12 +59,7 @@
"width": 0.0
}
],
"drc_exclusions": [
"silk_over_copper|76200000|114815000|87b8b328-7c18-46dd-9c02-abb9ed66fc64|926f1372-a754-462d-b6bc-e9e4c844a0d4",
"silk_over_copper|76200000|124015000|87b8b328-7c18-46dd-9c02-abb9ed66fc64|7a6114dc-3e6e-4244-a026-dd5cc7d536f2",
"silk_over_copper|76200000|82740000|87b8b328-7c18-46dd-9c02-abb9ed66fc64|b088434a-b9ba-4be7-88e6-4a2943e64cc2",
"silk_over_copper|76200000|95060000|87b8b328-7c18-46dd-9c02-abb9ed66fc64|4c921ba0-fa7f-44b2-ab6c-5233c1322f1f"
],
"drc_exclusions": [],
"meta": {
"version": 2
},
@ -612,7 +607,7 @@
"sheets": [
[
"0f636aba-d290-427e-af40-e046961774ac",
""
"Root"
],
[
"069afe5b-33fc-4c81-8e14-9833c58df62f",

SingleBoardComputer.kicad_sch
View File

LOADING

VREG_5V_3.3V.kicad_sch
View File

LOADING
RevaReviewa commented 2024-10-17 03:28:06 +00:00
Review
Copy Link

@AllSpiceAlice, can we disconnect SCK from this buffer? We're getting interference.

!thumbnail[](VREG_5V_3.3V.kicad_sch){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...f0c6d1baba28db424093a9ac75be40fd55c2c518" pr="8" doc-id="3c86f159e194b13ca2d9" diff-visibility="full" variant="default" view-coords="5.4,45.6,33.0,67.0" aspect-ratio="1.405" } @AllSpiceAlice, can we disconnect SCK from this buffer? We're getting interference.
AllSpiceAlice commented 2024-10-17 03:29:08 +00:00
Review
Copy Link

@RevaReviewa , Removed

!thumbnail[](VREG_5V_3.3V.kicad_sch){ diff="AllSpice-Demos/KiCAD-Demo:8a26e4d6dbeb69a5cd3cbba54807ba080ccb3192...a3c822e27c2b431d95cff1fd8b9d166fa3007c5e" pr="8" doc-id="3c86f159e194b13ca2d9" diff-visibility="full" variant="default" view-coords="5.2,43.3,34.5,65.2" aspect-ratio="1.405" } @RevaReviewa , Removed
RevaReviewa commented 2024-10-17 03:30:15 +00:00
Review
Copy Link

@AllSpiceAlice did you park the comparator? You need to check the datasheet to see if you need to pull up/down the inputs/outputs when not in use?

@AllSpiceAlice did you park the comparator? You need to check the datasheet to see if you need to pull up/down the inputs/outputs when not in use?
AllSpiceAlice commented 2024-10-17 03:30:43 +00:00
Review
Copy Link

@RevaReviewa I did not! Thank you for spotting that!

@RevaReviewa I did not! Thank you for spotting that!