AllSpice-Resources/Altium-Library-Demo
12
Fork 0
Files Issues 4 Design Reviews 1 Actions Releases Activity

Update to V4 #2

Open
AllSpiceAlice wants to merge 1 commits from develop into main
pull from: develop
merge into: AllSpice-Resources:main
Conversation 3 Commits 1 Changes 4
AllSpiceAlice commented 2024-08-06 07:14:00 +00:00
Owner
Copy Link

Resolved Issues

ICs.schlib

  • Update symbol AT25SF161-SSHD-T, Fixes #3
    • Moved pins (power on left, output on right)

LEDs.schlib

  • Add color label to LEDs, Fixes #4

Resistor.schlib

  • Fix resistor (10k->1)

footprints.pcblib

  • Fix pads on ADuM4160. Pads width was too small, Fixes #5

Description

...

Design Review Checklist

Process

  • Commits in correct branch
  • File names follow standard
  • Update project README page

System

  • Power
    • Supply rated for necessary country specifications
    • Estimated total worst-case power supply draw
  • Connectors
    • Sufficient Current and Voltage rating
    • Mating connectors have matching pinout
    • Same contact material specified for mating connectors
  • Testing
    • Test procedure written
  • Environmental
    • Specified min/max operating temperature
    • Specified min/max storage temperature
    • Specified min/max humidity
  • ROHS compliance requirement review

Components

  • Components meet environmental specifications
  • All components have quantity, reference designator and description
  • Suggested and alternate manufacturers listed
  • Price and stock checked for each component
  • Component derating
    • Voltage
    • Current
    • Power at worst-case operating temperature
    • Temperature at worst-case power

Schematics

  • Microcontrollers / ICs
    • Check the data sheet errata and apnotes for weird IC behaviors
  • Busses
  • Analog
    • Sufficient power rails for analog circuits
    • Amplifiers checked for stability
    • Consider signal rate-of-rise and fall for noise radiation
  • General
    • Sufficient bulk capacitance calculated
    • Polarized components checked
    • Electrolytic/tantalum capacitors checked for no reverse voltage
    • Electrolytic/tantalum capacitors temperature/voltage derating sufficient for MTBF
    • Check pin numbers of all custom-generated parts
    • Check reverse base-emitter current/voltage on bipolar transistors
    • Power nets use preferred and consistent naming (ex. no 3.3V vs +3.3V)
    • Debug resources added by design (leds, serial ports, etc.) even if unpopulated by default

PCB

  • Manufacturing
    • PCB manufacturing requirements noted on fab layer
      • Plating specified
        • Plating material
        • Plating thickness
      • Layer stack-up specified
      • Minimum trace/space specified
      • Minimum hole size specified
      • Controlled impedance specified
      • Blind or buried vias specified
  • Footprints
    • Pin 1 marked in a consistent manner
    • Component polarity marked
      • Diodes, LEDs
      • Electrolytic, tantalum capacitors
      • Keyed components like connectors
    • Footprint dimensions cross-checked with datasheet recommendation
    • Sufficient thermal pads on high-power components or nets
  • Clearance
    • Keep-out areas honored
      • Around mounting holes
      • For programming tools
      • For assembly tools (wrenches, screwdrivers etc.)
      • For connectors
    • Trace-to-trace clearance based upon voltage rating
    • Component size based upon voltage rating
  • Mechanical
    • CAD file uploaded
    • Clearance above connectors
    • Clearance below through-hole components
    • Mounting holes electrically isolated if necessary
      • Mounting holes have via stitching
    • Hole diameters leave margin for plating
  • Electrical
    • ERC passes
    • Isolation barriers are large enough
  • Signal integrity
    • Gaps in ground planes checked and minimized
    • High-speed signals avoid gaps in ground planes
    • Stubs minimized for high-speed signals
    • Differential pair spacing based upon impedance matching
    • Via fencing of sensitive RF transission lines done with the proper via spacing (< 1/20 lambda)
    • Option for a shielding can over sensitive circuitry e.g. RF?
  • Copper pour
    • All planes have been poured
    • Planes and pours checked for high-impedance paths
    • No pour between adjacent pins on ICs
  • Traces
    • Trace-pad connections sufficiently obtuse (angle 90 deg or more)
    • Trace widths sufficient for the current draw and max heating
    • No connections between adjacent pins on ICs
    • Vias for internal power traces sufficiently large
    • Mitered bends or soft curves (r > 3 trace width) for impedance sensitive traces
  • Thermal
    • Temperature sensitive components placed away from hot components
    • Thermal vias in thermal pads
  • Silk screen
    • Notes and documentation
      • Updated revision number
      • Updated date
    • No silk screen over pads / vias
    • Text is readable from at most two directions
    • Silk screen size / font will legible after printing
    • Connector pin-outs labeled
    • Fuse size and type marked on PCB
    • Functional groups marked
    • Functionality labeled
      • Test points
      • LEDs
      • Buttons
      • Connectors/terminals
      • Jumpers/fuses
## Resolved Issues ### ICs.schlib - Update symbol AT25SF161-SSHD-T, Fixes #3 - Moved pins (power on left, output on right) ### LEDs.schlib - Add color label to LEDs, Fixes #4 ### Resistor.schlib - Fix resistor (10k->1) ### footprints.pcblib - Fix pads on ADuM4160. Pads width was too small, Fixes #5 ## Description <!-- Include a description for this design review. What is the primary purpose? What will be the status of this design after approval? --> ... ## Design Review Checklist ### Process - [ ] Commits in correct branch - [ ] File names follow standard - [ ] Update project README page ### System - [ ] Power - [ ] Supply rated for necessary country specifications - [ ] Estimated total worst-case power supply draw - [ ] Connectors - [ ] Sufficient Current and Voltage rating - [ ] Mating connectors have matching pinout - [ ] Same contact material specified for mating connectors - [ ] Testing - [ ] Test procedure written - [ ] Environmental - [ ] Specified min/max operating temperature - [ ] Specified min/max storage temperature - [ ] Specified min/max humidity - [ ] ROHS compliance requirement review ### Components - [ ] Components meet environmental specifications - [ ] All components have quantity, reference designator and description - [ ] Suggested and alternate manufacturers listed - [ ] Price and stock checked for each component - [ ] Component derating - [ ] Voltage - [ ] Current - [ ] Power at worst-case operating temperature - [ ] Temperature at worst-case power ### Schematics - [ ] Microcontrollers / ICs - [ ] Check the data sheet errata and apnotes for weird IC behaviors - [ ] Busses - [ ] UART/USART TX->RX and RX<-TX - [ ] I2C SDA and SCL pins correct(https://www.ti.com/lit/an/slva689/slva689.pdf) - [ ] Analog - [ ] Sufficient power rails for analog circuits - [ ] Amplifiers checked for stability - [ ] Consider signal rate-of-rise and fall for noise radiation - [ ] General - [ ] Sufficient bulk capacitance calculated - [ ] Polarized components checked - [ ] Electrolytic/tantalum capacitors checked for no reverse voltage - [ ] Electrolytic/tantalum capacitors temperature/voltage derating sufficient for MTBF - [ ] Check pin numbers of all custom-generated parts - [ ] Check reverse base-emitter current/voltage on bipolar transistors - [ ] Power nets use preferred and consistent naming (ex. no `3.3V` vs `+3.3V`) - [ ] Debug resources added by design (leds, serial ports, etc.) even if unpopulated by default ### PCB - [ ] Manufacturing - [ ] PCB manufacturing requirements noted on `fab` layer - [ ] Plating specified - [ ] Plating material - [ ] Plating thickness - [ ] Layer stack-up specified - [ ] Minimum trace/space specified - [ ] Minimum hole size specified - [ ] Controlled impedance specified - [ ] Blind or buried vias specified - [ ] Footprints - [ ] Pin 1 marked in a consistent manner - [ ] Component polarity marked - [ ] Diodes, LEDs - [ ] Electrolytic, tantalum capacitors - [ ] Keyed components like connectors - [ ] Footprint dimensions cross-checked with datasheet recommendation - [ ] Sufficient thermal pads on high-power components or nets - [ ] Clearance - [ ] Keep-out areas honored - [ ] Around mounting holes - [ ] For programming tools - [ ] For assembly tools (wrenches, screwdrivers etc.) - [ ] For connectors - [ ] Trace-to-trace clearance based upon voltage rating - [ ] Component size based upon voltage rating - [ ] Mechanical - [ ] CAD file uploaded - [ ] Clearance above connectors - [ ] Clearance below through-hole components - [ ] Mounting holes electrically isolated if necessary - [ ] Mounting holes have via stitching - [ ] Hole diameters leave margin for plating - [ ] Electrical - [ ] ERC passes - [ ] Isolation barriers are large enough - [ ] Signal integrity - [ ] Gaps in ground planes checked and minimized - [ ] High-speed signals avoid gaps in ground planes - [ ] Stubs minimized for high-speed signals - [ ] Differential pair spacing based upon impedance matching - [ ] Via fencing of sensitive RF transission lines done with the proper via spacing (< 1/20 lambda) - [ ] Option for a shielding can over sensitive circuitry e.g. RF? - [ ] Copper pour - [ ] All planes have been poured - [ ] Planes and pours checked for high-impedance paths - [ ] No pour between adjacent pins on ICs - [ ] Traces - [ ] Trace-pad connections sufficiently obtuse (angle 90 deg or more) - [ ] Trace widths sufficient for the current draw and max heating - [ ] No connections between adjacent pins on ICs - [ ] Vias for internal power traces sufficiently large - [ ] Mitered bends or soft curves (r > 3 trace width) for impedance sensitive traces - [ ] Thermal - [ ] Temperature sensitive components placed away from hot components - [ ] Thermal vias in thermal pads - [ ] Silk screen - [ ] Notes and documentation - [ ] Updated revision number - [ ] Updated date - [ ] No silk screen over pads / vias - [ ] Text is readable from at most two directions - [ ] Silk screen size / font will legible after printing - [ ] Connector pin-outs labeled - [ ] Fuse size and type marked on PCB - [ ] Functional groups marked - [ ] Functionality labeled - [ ] Test points - [ ] LEDs - [ ] Buttons - [ ] Connectors/terminals - [ ] Jumpers/fuses <!-- Special thanks to Henrik Enggaard Hansen for https://pcbchecklist.com/ -->
AllSpiceAlice added 1 commit 2024-08-06 07:14:01 +00:00
AllSpiceAlice requested review from RevaReviewa 2024-08-06 07:14:13 +00:00
AllSpiceAlice requested review from MikaChanical 2024-08-06 07:14:13 +00:00
AllSpiceAlice requested review from PavelInPurchasing 2024-08-06 07:14:13 +00:00
AllSpiceAlice requested review from daniel-allspice 2024-08-06 07:14:13 +00:00
AllSpiceAlice added the
layout
mechanical
 labels 2024-08-06 07:14:23 +00:00
RevaReviewa commented 2024-08-06 07:30:49 +00:00
First-time contributor
Copy Link

Thank you for the updates to the footprints.pcblib! The new pads should pass the DFM test!

Thank you for the updates to the footprints.pcblib! The new pads should pass the DFM test!
PavelInPurchasing commented 2024-08-06 07:32:09 +00:00
First-time contributor
Copy Link

@daniel , can you verify the symbol matches the APL?

@daniel , can you verify the symbol matches the APL?
daniel-allspice commented 2024-08-06 07:33:18 +00:00
First-time contributor
Copy Link

@daniel , can you verify the symbol matches the APL?

@PavelInPurchasing, Yes, we changed the 10K symbol to 1K. We should be good to go!

> @daniel , can you verify the symbol matches the APL? @PavelInPurchasing, Yes, we changed the 10K symbol to 1K. We should be good to go!
This design review can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this design review.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin develop:develop
git checkout develop
Sign in to join this conversation.
Reviewers
No Reviewers
RevaReviewa
MikaChanical
PavelInPurchasing
daniel-allspice
Labels
Clear labels
bug
Something doesn't work
dfm
Design for manufacturing consideration
documentation
Improvements to supporting documentation
eol
End of life component
feature
New feature or request
firmware
Requires FW attention
layout
Requires PCB layout attention
mechanical
Requires ME attention
priority/1 - idea
Nice to have or idea to capture
priority/2 - low
Should be resolved eventually
priority/3 - medium
Should be resolved before product launch
priority/4 - high
Should be resolved before next release
priority/5 - critical
Must be fixed immediately - blocking item
No Label
layout
mechanical
Milestone
No items
No Milestone
Assignees
Clear assignees
AllSpiceAlice allspice-hermes allspice-kyle allspice-thomas gautam McRaeAlex rowan sam Tayawiggins
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: AllSpice-Resources/Altium-Library-Demo#2
No description provided.
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?