Update channel count and clean up documentation #15

Closed

AllSpiceAlice wants to merge 9 commits from feature_branch into main

AllSpiceAlice commented

2023-03-30 16:57:19 +00:00

Contributor

This short description prepends any pull request. It is fully markdown compatible. See markdown guide for examples of what you can do!

Resolved Issues

...

Description

...

Design Review Checklist

Process

Commits in correct branch
Schematic and PCB file names follow standard
Export necessary review files (3D model, BOM, etc.)
Update relevant system architecture documents
Update project README page
Simulations uploaded and outputs explained

System

Power
- Sufficient power supplied from upstream source
- Supply rated for necessary country specifications
- Estimated total worst-case power supply draw
Connectors
- I/Os are specified
- Sufficient Current and Voltage rating
- Mating connectors have matching pinout
- Same contact material specified for mating connectors
Testing
- Test procedure written
Environmental
- Specified min/max operating temperature
- Specified min/max storage temperature
- Specified min/max humidity
ROHS compliance requirement review

Components

Unpopulated components are denoted DNI
Components meet environmental specifications
All components have quantity, reference designator and description
Suggested and alternate manufacturers listed
Price and stock checked for each component
Component derating
- Voltage
- Current
- Power at worst-case operating temperature
- Temperature at worst-case power

Schematics

Document
- Dot on each connection
- No four-point connections
- Title block completed for each sheet
- All components have reference designators and values
- Multi-part components don't have unplaced symbols
- Page title present and consistent on all pages if not in title block
- Symbols identify open collector/drain pins and internal pulled up/down pins
- Pin names and attributes on symbols with multi-function pins should match actual design usage (I/O/Bi, Name)
- Components follow preferred reference designator pattern
External I/O
- Filtered for EMI
- Protected against electrostatic discharge (ESD)
- Unused inputs terminated
Microcontrollers / ICs
- Predictable or controlled power-up state
  - Reset filtered
- Sufficient bypass capacitance
- Oscillators checked for reliable startup
- Pullups on open-collector pins
- Logic-low and logic-high voltage levels checked
- No-connect pins labeled NC
- Clock lines with series termination and parallel termination component locations present even if not populated; zero ohm resistor for series, unpopulated parts for parallel termination
- Check for input voltages applied with power off and CMOS latchup possibilities
- Check the data sheet errata and apnotes for weird IC behaviors
Busses
- UART/USART TX->RX and RX<-TX
- I2C SDA and SCL pullup with appropriate value per capacitance
- Setup, hold, access times for data and address busses
Analog
- Sufficient power rails for analog circuits
- Amplifiers checked for stability
- Consider signal rate-of-rise and fall for noise radiation
General
- Sufficient bulk capacitance calculated
- Polarized components checked
- Electrolytic/tantalum capacitors checked for no reverse voltage
- Electrolytic/tantalum capacitors temperature/voltage derating sufficient for MTBF
- Sufficient capacitance on low dropout voltage regulators
- Sufficient time delays and slew rates for comparators
- Sufficient common mode input voltage rating on opamps
- Check pin numbers of all custom-generated parts
- Check reverse base-emitter current/voltage on bipolar transistors
- Power nets use preferred and consistent naming (ex. no 3.3V vs +3.3V)
- Debug resources added by design (leds, serial ports, etc.) even if unpopulated by default

PCB

Manufacturing
- PCB manufacturing requirements noted on fab layer
  - Plating specified
    - Plating material
    - Plating thickness
  - Layer stack-up specified
  - Minimum trace/space specified
  - Minimum hole size specified
  - PCB color specified
  - Silkscreen color specified
  - Controlled impedance specified
  - Blind or buried vias specified
  - Panelization specified
    - External routing specified (ex. v-groove vs route)
  - Drill table generated
  - All specifications exceed manufacturing tolerance
- Space between power planes minimized
- Solder paste openings proper size
- Fiducials placed if necessary
Footprints
- Pin 1 marked in a consistent manner
- Component polarity marked
  - Diodes, LEDs
  - Electrolytic, tantalum capacitors
  - Keyed components like connectors
- Footprint dimensions cross-checked with datasheet recommendation
- Sufficient thermal pads on high-power components or nets
Placement
- Jumpers accessible
- Debug connectors accessible
- Filter resistors closer to source
- Termination resistors close to target
- Small loop path on switch-mode power supplies
- Bypass capacitors close to ICs
- Bypass capacitors close to connectors
- Drivers / receivers close to connectors
- SMT components on top side, through-hole components on bottom side if possible
Clearance
- Keep-out areas honored
  - Around mounting holes
  - For programming tools
  - For assembly tools (wrenches, screwdrivers etc.)
  - For connectors
- Trace-to-trace clearance based upon voltage rating
- Component size based upon voltage rating
- Keep components away from board edge
Mechanical
- CAD file uploaded
- Clearance above connectors
- Clearance below through-hole components
- Enough space for the minimum bending radius of the wire harness
- Mounting holes electrically isolated if necessary
  - Mounting holes have via stitching
- Hole diameters leave margin for plating
- Board outline defined
- Mechanical enclosure defined
- Internal corners are rounded and can be milled
Electrical
- All traces are routed
- Analog and digital commons joined at only one point
- ERC passes
- Isolation barriers are large enough
Signal integrity
- Gaps in ground planes checked and minimized
- High-speed signals avoid gaps in ground planes
- Stubs minimized for high-speed signals
- Differential pair spacing based upon impedance matching
- Transmission lines terminated with an appropriate impedance
- Crystal connections kept short
- Guard ring around crystals
- Traces avoided under sensitive components
- Traces avoided under noisy components
- Via fencing of sensitive RF transission lines done with the proper via spacing (< 1/20 lambda)
- Option for a shielding can over sensitive circuitry e.g. RF?
Copper pour
- All planes have been poured
- Planes and pours checked for high-impedance paths
- No pour between adjacent pins on ICs
Traces
- Trace-pad connections sufficiently obtuse (angle 90 deg or more)
- Trace widths sufficient for the current draw and max heating
- No connections between adjacent pins on ICs
- Vias for internal power traces sufficiently large
- Mitered bends or soft curves (r > 3 trace width) for impedance sensitive traces
Thermal
- Temperature sensitive components placed away from hot components
- Thermal vias in thermal pads
Testing
- Test points on PCBs for critical circuits, hard to reach nets
- Ground connection points close to analog test points
Silk screen
- Notes and documentation
  - Updated revision number
  - Updated date
  - Blank space designated for a serial / assembly number
- No silk screen over pads / vias
- Text is readable from at most two directions
- Silk screen size / font will legible after printing
- Connector pin-outs labeled
- Fuse size and type marked on PCB
- Functional groups marked
- Functionality labeled
  - Test points
  - LEDs
  - Buttons
  - Connectors/terminals
  - Jumpers/fuses

*This short description prepends any pull request. It is fully markdown compatible. See [markdown guide](https://www.markdownguide.org/cheat-sheet/) for examples of what you can do!* ## Resolved Issues  ... ## Description  ... ## Design Review Checklist ### Process - [x] Commits in correct branch - [x] Schematic and PCB file names follow standard - [x] Export necessary review files (3D model, BOM, etc.) - [x] Update relevant system architecture documents - [x] Update project README page - [x] Simulations uploaded and outputs explained ### System - [x] Power - [x] Sufficient power supplied from upstream source - [x] Supply rated for necessary country specifications - [x] Estimated total worst-case power supply draw - [x] Connectors - [x] I/Os are specified - [x] Sufficient Current and Voltage rating - [x] Mating connectors have matching pinout - [x] Same contact material specified for mating connectors - [ ] Testing - [ ] Test procedure written - [ ] Environmental - [ ] Specified min/max operating temperature - [ ] Specified min/max storage temperature - [ ] Specified min/max humidity - [ ] ROHS compliance requirement review ### Components - [ ] Unpopulated components are denoted DNI - [ ] Components meet environmental specifications - [ ] All components have quantity, reference designator and description - [ ] Suggested and alternate manufacturers listed - [ ] Price and stock checked for each component - [ ] Component derating - [ ] Voltage - [ ] Current - [ ] Power at worst-case operating temperature - [ ] Temperature at worst-case power ### Schematics - [ ] Document - [ ] Dot on each connection - [ ] No four-point connections - [ ] Title block completed for each sheet - [ ] All components have reference designators and values - [ ] Multi-part components don't have unplaced symbols - [ ] Page title present and consistent on all pages if not in title block - [ ] Symbols identify open collector/drain pins and internal pulled up/down pins - [ ] Pin names and attributes on symbols with multi-function pins should match actual design usage (I/O/Bi, Name) - [ ] Components follow preferred reference designator pattern  - [ ] External I/O - [ ] Filtered for EMI - [ ] Protected against electrostatic discharge (ESD) - [ ] Unused inputs terminated - [ ] Microcontrollers / ICs - [ ] Predictable or controlled power-up state - [ ] Reset filtered - [ ] Sufficient bypass capacitance - [ ] Oscillators checked for reliable startup - [ ] Pullups on open-collector pins - [ ] Logic-low and logic-high voltage levels checked - [ ] No-connect pins labeled NC - [ ] Clock lines with series termination and parallel termination component locations present even if not populated; zero ohm resistor for series, unpopulated parts for parallel termination - [ ] Check for input voltages applied with power off and CMOS latchup possibilities - [ ] Check the data sheet errata and apnotes for weird IC behaviors - [x] Busses - [ ] UART/USART TX->RX and RX<-TX - [ ] I2C SDA and SCL pullup with appropriate value [per capacitance](https://www.ti.com/lit/an/slva689/slva689.pdf) - [ ] Setup, hold, access times for data and address busses - [ ] Analog - [ ] Sufficient power rails for analog circuits - [ ] Amplifiers checked for stability - [ ] Consider signal rate-of-rise and fall for noise radiation - [ ] General - [ ] Sufficient bulk capacitance calculated - [ ] Polarized components checked - [ ] Electrolytic/tantalum capacitors checked for no reverse voltage - [ ] Electrolytic/tantalum capacitors temperature/voltage derating sufficient for MTBF - [ ] Sufficient capacitance on low dropout voltage regulators - [ ] Sufficient time delays and slew rates for comparators - [ ] Sufficient common mode input voltage rating on opamps - [ ] Check pin numbers of all custom-generated parts - [ ] Check reverse base-emitter current/voltage on bipolar transistors - [ ] Power nets use preferred and consistent naming (ex. no `3.3V` vs `+3.3V`) - [ ] Debug resources added by design (leds, serial ports, etc.) even if unpopulated by default ### PCB - [ ] Manufacturing - [ ] PCB manufacturing requirements noted on `fab` layer - [ ] Plating specified - [ ] Plating material - [ ] Plating thickness - [ ] Layer stack-up specified - [ ] Minimum trace/space specified - [ ] Minimum hole size specified - [ ] PCB color specified - [ ] Silkscreen color specified - [ ] Controlled impedance specified - [ ] Blind or buried vias specified - [ ] Panelization specified - [ ] External routing specified (ex. v-groove vs route) - [ ] Drill table generated - [ ] All specifications exceed manufacturing tolerance - [ ] Space between power planes minimized - [ ] Solder paste openings proper size - [ ] Fiducials placed if necessary - [ ] Footprints - [ ] Pin 1 marked in a consistent manner - [ ] Component polarity marked - [ ] Diodes, LEDs - [ ] Electrolytic, tantalum capacitors - [ ] Keyed components like connectors - [ ] Footprint dimensions cross-checked with datasheet recommendation - [ ] Sufficient thermal pads on high-power components or nets - [ ] Placement - [ ] Jumpers accessible - [ ] Debug connectors accessible - [ ] Filter resistors closer to source - [ ] Termination resistors close to target - [ ] Small loop path on switch-mode power supplies - [ ] Bypass capacitors close to ICs - [ ] Bypass capacitors close to connectors - [ ] Drivers / receivers close to connectors - [ ] SMT components on top side, through-hole components on bottom side if possible - [ ] Clearance - [ ] Keep-out areas honored - [ ] Around mounting holes - [ ] For programming tools - [ ] For assembly tools (wrenches, screwdrivers etc.) - [ ] For connectors - [ ] Trace-to-trace clearance based upon voltage rating - [ ] Component size based upon voltage rating - [ ] Keep components away from board edge - [ ] Mechanical - [ ] CAD file uploaded - [ ] Clearance above connectors - [ ] Clearance below through-hole components - [ ] Enough space for the minimum bending radius of the wire harness - [ ] Mounting holes electrically isolated if necessary - [ ] Mounting holes have via stitching - [ ] Hole diameters leave margin for plating - [ ] Board outline defined - [ ] Mechanical enclosure defined - [ ] Internal corners are rounded and can be milled - [ ] Electrical - [ ] All traces are routed - [ ] Analog and digital commons joined at only one point - [ ] ERC passes - [ ] Isolation barriers are large enough - [ ] Signal integrity - [ ] Gaps in ground planes checked and minimized - [ ] High-speed signals avoid gaps in ground planes - [ ] Stubs minimized for high-speed signals - [ ] Differential pair spacing based upon impedance matching - [ ] Transmission lines terminated with an appropriate impedance - [ ] Crystal connections kept short - [ ] Guard ring around crystals - [ ] Traces avoided under sensitive components - [ ] Traces avoided under noisy components - [ ] Via fencing of sensitive RF transission lines done with the proper via spacing (< 1/20 lambda) - [ ] Option for a shielding can over sensitive circuitry e.g. RF? - [ ] Copper pour - [ ] All planes have been poured - [ ] Planes and pours checked for high-impedance paths - [ ] No pour between adjacent pins on ICs - [ ] Traces - [ ] Trace-pad connections sufficiently obtuse (angle 90 deg or more) - [ ] Trace widths sufficient for the current draw and max heating - [ ] No connections between adjacent pins on ICs - [ ] Vias for internal power traces sufficiently large - [ ] Mitered bends or soft curves (r > 3 trace width) for impedance sensitive traces - [ ] Thermal - [ ] Temperature sensitive components placed away from hot components - [ ] Thermal vias in thermal pads - [ ] Testing - [ ] Test points on PCBs for critical circuits, hard to reach nets - [ ] Ground connection points close to analog test points - [ ] Silk screen - [ ] Notes and documentation - [ ] Updated revision number - [ ] Updated date - [ ] Blank space designated for a serial / assembly number - [ ] No silk screen over pads / vias - [ ] Text is readable from at most two directions - [ ] Silk screen size / font will legible after printing - [ ] Connector pin-outs labeled - [ ] Fuse size and type marked on PCB - [ ] Functional groups marked - [ ] Functionality labeled - [ ] Test points - [ ] LEDs - [ ] Buttons - [ ] Connectors/terminals - [ ] Jumpers/fuses

AllSpiceAlice added the

3 - medium

documentation

labels 2023-03-30 16:57:19 +00:00

AllSpiceAlice added 8 commits 2023-03-30 16:57:21 +00:00

a5b3049f02 Clean up wiring

4cf7e23ce1 Clean up for documentation

741268457f Lower bias resistor and add test points to end-stop

238f1b5184 Add debug header

5da9a47411 Add extra bypass cap

1bd3d82937 Remove heatbed channel

b1aee00e38 Add missing gnd pin

dceda70536 Remove thermocouple E to make room

AllSpiceAlice reviewed 2023-03-30 16:58:43 +00:00

Archimajor.PcbDoc

AllSpiceAlice commented

2023-03-30 16:58:29 +00:00

Author

Contributor

@RevaReviewa Can you see if there is another place to put these components?

!thumbnail[](Archimajor.PcbDoc){ diff="ProductDevelopmentFirm/ArchimajorDemo:a383e008f58436565307e755b6a3a8db2d561eff...dceda7053642f971601ffb6e1deba65a03685ebb" pr="15" layers="82,74,72,71,69,68,66,65,64,63,60,59,58,57,33,35,37,1,41,40,2,39,32,38,34" diff-visibility="full" variant="default" view-coords="59.2,9.9,68.9,22.8" aspect-ratio="1.345" } @RevaReviewa Can you see if there is another place to put these components?

RevaReviewa requested review from RevaReviewa 2023-03-30 16:59:47 +00:00

RevaReviewa requested review from MikaChanical 2023-03-30 16:59:55 +00:00

RevaReviewa requested review from PavelInPurchasing 2023-03-30 16:59:55 +00:00

RevaReviewa reviewed 2023-03-30 17:02:13 +00:00

EndStops.SchDoc

RevaReviewa commented

2023-03-30 17:02:13 +00:00

Member

Have we verified these values experimentally?

!thumbnail[](EndStops.SchDoc){ diff="ProductDevelopmentFirm/ArchimajorDemo:a383e008f58436565307e755b6a3a8db2d561eff...dceda7053642f971601ffb6e1deba65a03685ebb" pr="15" diff-visibility="full" variant="default" view-coords="46.3,51.0,82.4,86.4" aspect-ratio="1.284" } Have we verified these values experimentally?

AllSpiceAlice reviewed 2023-03-30 18:14:27 +00:00

EndStops.SchDoc

AllSpiceAlice commented

2023-03-30 18:14:27 +00:00

Author

Contributor

Please select new manufacturer part

!thumbnail[](EndStops.SchDoc){ diff="ProductDevelopmentFirm/ArchimajorDemo:a383e008f58436565307e755b6a3a8db2d561eff...dceda7053642f971601ffb6e1deba65a03685ebb" pr="15" diff-visibility="full" variant="default" view-coords="46.2,49.8,74.4,69.0" aspect-ratio="1.284" } Please select new manufacturer part

AllSpiceAlice marked this conversation as resolved

AllSpiceAlice added 1 commit 2023-03-30 18:25:20 +00:00

7dd03be262 Add copy of channel

AllSpiceAlice added this to the Release V2 milestone 2023-06-12 20:51:50 +00:00

AllSpiceAlice added a new dependency 2023-06-12 20:52:26 +00:00

#27 Verify experimental values

AllSpiceAlice closed this pull request

2023-08-28 21:02:29 +00:00

AllSpiceAlice reviewed 2023-09-22 02:27:06 +00:00

Mosfets.SchDoc

AllSpiceAlice commented

2023-09-22 02:27:06 +00:00

Author

Contributor

@Allie Add this channel back. We're removing it in Rev 4, not rev 3

!thumbnail[](Mosfets.SchDoc){ diff="ProductDevelopmentFirm/ArchimajorDemo:a383e008f58436565307e755b6a3a8db2d561eff...7dd03be262bf483bd2c264ba37e84c01a9d3015c" pr="15" diff-visibility="full" variant="default" view-coords="3.5,54.8,83.8,81.9" aspect-ratio="1.284" } @Allie Add this channel back. We're removing it in Rev 4, not rev 3

This repo is archived. You cannot comment on pull requests.

No reviewers