Features/bottombar redux #97

Merged

A-Nilfgaardian merged 7 commits from features/bottombar-redux into master

2021-01-20 14:34:28 +00:00

A-Nilfgaardian commented

2021-01-17 00:18:36 +00:00

(Migrated from github.com)

Changes

Removed a bunch of prop passing from App.tsx to BottomBar.tsx
Cleaned up BottomBar.tsx file to remove all props no longer needed
Wrapped the following components in Redux and changed all information to be pulled from the store instead of being passed in as a prop
- channel.tsx
- timeperdivision.tsx
- trigger.tsx
Cleaned up horizontalWidget.tsx and verticalWidget.tsx code to better reflect new changes
Created a configuration directory to hold a bunch of default values, enums, etc.
Added the user-select: none style field to many components to prevent copying and highlighting of text fields
Refactored the reducer files to be cleaner and to use less code
Added a reducer for the upcoming triggering widget

Issues Addressed

Next Steps

Clean up the Horizontal Widget #91
Clean up the Vertical Widget #92
Create the Trigger Widget #93

Screenshot

Pretty much looks identical to master, except that the horizontal and vertical time bases are now using the preset units instead of being a simple counter.

**Changes** * Removed a bunch of prop passing from `App.tsx` to `BottomBar.tsx` * Cleaned up `BottomBar.tsx` file to remove all props no longer needed * Wrapped the following components in Redux and changed all information to be pulled from the store instead of being passed in as a prop * `channel.tsx` * `timeperdivision.tsx` * `trigger.tsx` * Cleaned up `horizontalWidget.tsx` and `verticalWidget.tsx` code to better reflect new changes * Created a `configuration` directory to hold a bunch of default values, enums, etc. * Added the `user-select: none` style field to many components to prevent copying and highlighting of text fields * Refactored the reducer files to be cleaner and to use less code * Added a reducer for the upcoming triggering widget **Issues Addressed** * #94 **Next Steps** * Clean up the Horizontal Widget #91 * Clean up the Vertical Widget #92 * Create the Trigger Widget #93 **Screenshot** * Pretty much looks identical to master, except that the horizontal and vertical time bases are now using the preset units instead of being a simple counter. ![Screenshot 2021-01-16 190613](https://user-images.githubusercontent.com/38380270/104827657-1f315a00-582e-11eb-8d56-bcefe1ef22cd.png)

ratanvarghese (Migrated from github.com) reviewed 2021-01-17 00:18:36 +00:00

No reviewers

ratanvarghese