allspice-kyle/Dual-Lane-Feeder-Controller
1
Fork 0
Files Issues 2 Design Reviews 1 Releases Activity

Fix Power Supply Vfb #1

Open
allspice-kyle wants to merge 3 commits from develop into master
pull from: develop
merge into: allspice-kyle:master
Conversation 0 Commits 3 Files Changed 6
5 changed files with 0 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ceb72a6cd3 - Show all commits

Controller.SchDoc
View File

LOADING

BIN
Feeder Board.PCBDwf
View File

Binary file not shown.

Feeder Board.PcbDoc
View File

LOADING
allspice-kyle commented 2022-07-21 18:12:06 +00:00
Review
Copy Link

@mark-hughes did this EOL connector get reviewed?

!thumbnail[](Feeder Board.PcbDoc){ diff="kyle/Dual-Lane-Feeder-Controller:c7daa5edbd01ca422c204fdf94d4f87e01895f71...410e2990466b4d01bafe371cc990717296bd1908" pr="1" layers="82,74,72,71,69,65,56,33,1,32,34" diff-visibility="full" variant="default" view-coords="5.3,0.5,12.2,26.5" aspect-ratio="6.817" } @mark-hughes did this EOL connector get reviewed?
mark-hughes commented 2022-07-21 18:12:43 +00:00
Review
Copy Link

Double check the land pattern here -- looks like some trace stubs on the land pattern.

!thumbnail[](Feeder Board.PcbDoc){ diff="kyle/Dual-Lane-Feeder-Controller:c7daa5edbd01ca422c204fdf94d4f87e01895f71...410e2990466b4d01bafe371cc990717296bd1908" pr="1" layers="82,74,72,71,69,65,56,33,1,32,34" diff-visibility="full" variant="default" view-coords="42.8,31.4,45.7,48.1" aspect-ratio="6.817" } Double check the land pattern here -- looks like some trace stubs on the land pattern.
mark-hughes commented 2022-07-21 18:16:40 +00:00
Review
Copy Link

Remember to check for shorts.

!thumbnail[](Feeder Board.PcbDoc){ diff="kyle/Dual-Lane-Feeder-Controller:c7daa5edbd01ca422c204fdf94d4f87e01895f71...410e2990466b4d01bafe371cc990717296bd1908" pr="1" layers="1" diff-visibility="none" variant="default" view-coords="10.2,47.1,12.3,58.0" aspect-ratio="6.817" } Remember to check for shorts.
mark-hughes commented 2022-07-21 18:18:11 +00:00
Review
Copy Link

This will cause solder wicking. Check out IPC-7351?

!thumbnail[](Feeder Board.PcbDoc){ diff="kyle/Dual-Lane-Feeder-Controller:c7daa5edbd01ca422c204fdf94d4f87e01895f71...410e2990466b4d01bafe371cc990717296bd1908" pr="1" layers="82,1" diff-visibility="none" variant="default" view-coords="25.0,67.1,27.2,82.4" aspect-ratio="6.817" } This will cause solder wicking. Check out IPC-7351?
mark-hughes commented 2022-07-21 18:20:29 +00:00
Review
Copy Link

IPC-7351!

!thumbnail[](Feeder Board.PcbDoc){ diff="kyle/Dual-Lane-Feeder-Controller:c7daa5edbd01ca422c204fdf94d4f87e01895f71...410e2990466b4d01bafe371cc990717296bd1908" pr="1" layers="82,1" diff-visibility="none" variant="default" view-coords="50.3,13.1,54.8,34.7" aspect-ratio="6.817" } IPC-7351!
mark-hughes commented 2022-07-21 18:20:57 +00:00
Review
Copy Link

Not a problem at all.

!thumbnail[](Feeder Board.PcbDoc){ diff="kyle/Dual-Lane-Feeder-Controller:c7daa5edbd01ca422c204fdf94d4f87e01895f71...410e2990466b4d01bafe371cc990717296bd1908" pr="1" layers="82,1" diff-visibility="none" variant="default" view-coords="46.4,73.3,59.3,94.3" aspect-ratio="6.817" } Not a problem at all.
allspice-kyle marked this conversation as resolved
mark-hughes commented 2022-07-21 18:23:13 +00:00
Review
Copy Link

Check courtyard

!thumbnail[](Feeder Board.PcbDoc){ diff="kyle/Dual-Lane-Feeder-Controller:c7daa5edbd01ca422c204fdf94d4f87e01895f71...410e2990466b4d01bafe371cc990717296bd1908" pr="1" layers="71" diff-visibility="none" variant="default" view-coords="45.5,36.2,53.5,61.6" aspect-ratio="6.817" } Check courtyard
allspice-kyle commented 2022-07-21 18:32:19 +00:00
Review
Copy Link

All set. They are correct.

All set. They are correct.

Feeder Panel.PcbDoc
View File

LOADING

Power Supply.SchDoc
View File

LOADING
allspice-kyle commented 2022-07-21 18:27:30 +00:00
Review
Copy Link

Can we update this with a comment/note for what feedback values we chose.

!thumbnail[](Power Supply.SchDoc){ diff="kyle/Dual-Lane-Feeder-Controller:c7daa5edbd01ca422c204fdf94d4f87e01895f71...410e2990466b4d01bafe371cc990717296bd1908" pr="1" diff-visibility="full" variant="default" view-coords="67.5,24.5,72.1,29.2" aspect-ratio="1.282" } Can we update this with a comment/note for what feedback values we chose.