allspice-kyle/BACKUP-youtube-altium-quick-tutorial
1
Fork 0
Files Issues 2 Design Reviews 1 Projects 1 Releases

Delete redundant LED circuit #1

Merged
allspice-kyle merged 1 commits from develop into master 2023-01-09 17:33:33 +00:00
Conversation 5 Commits 1 Changes 3 +74 -86
allspice-kyle commented 2023-01-09 17:22:19 +00:00
Owner
Copy Link

Close #2

Delete redundant LED circuit

Close #2 Delete redundant LED circuit
allspice-kyle added 1 commit 2023-01-09 17:22:19 +00:00
Delete redundant LED circuit f7b05b8df9
allspice-kyle reviewed 2023-01-09 17:23:21 +00:00
LED.SchDoc
allspice-kyle commented 2023-01-09 17:23:21 +00:00
Author
Owner
Copy Link

This should be unchanged

!thumbnail[](LED.SchDoc){ diff="kyle/youtube-altium-quick-tutorial:2d630d1c3253bde24ab306d22ff06be771df0479...f7b05b8df9e0abc568fde7424d72d3acf0fe86d4" pr="1" diff-visibility="full" variant="default" view-coords="40.3,48.5,49.2,58.3" aspect-ratio="1.257" } This should be unchanged
allspice-kyle reviewed 2023-01-09 17:24:17 +00:00
LED.SchDoc
allspice-kyle commented 2023-01-09 17:24:17 +00:00
Author
Owner
Copy Link

Robert, can you take a look at this?

!thumbnail[](LED.SchDoc){ diff="kyle/youtube-altium-quick-tutorial:2d630d1c3253bde24ab306d22ff06be771df0479...f7b05b8df9e0abc568fde7424d72d3acf0fe86d4" pr="1" diff-visibility="full" variant="default" view-coords="32.1,34.5,40.9,43.0" aspect-ratio="1.257" } Robert, can you take a look at this?
allspice-kyle added this to the Test Project project 2023-01-09 17:33:22 +00:00
allspice-kyle merged commit c22418e217 into master 2023-01-09 17:33:33 +00:00
allspice-kyle requested review from Robert-B 2023-01-09 17:42:03 +00:00
allspice-kyle reviewed 2023-01-09 17:43:08 +00:00
LED.SchDoc
allspice-kyle commented 2023-01-09 17:43:08 +00:00
Author
Owner
Copy Link

@ApproverApril can you check this update?

!thumbnail[](LED.SchDoc){ diff="kyle/youtube-altium-quick-tutorial:2d630d1c3253bde24ab306d22ff06be771df0479...f7b05b8df9e0abc568fde7424d72d3acf0fe86d4" pr="1" diff-visibility="full" variant="default" view-coords="30.6,32.7,40.3,60.8" aspect-ratio="1.257" } @ApproverApril can you check this update?
Robert-B commented 2023-01-09 17:43:41 +00:00
Collaborator
Copy Link

👍 Looks good!

👍 Looks good!
Robert-B approved these changes 2023-01-09 17:44:20 +00:00
Robert-B left a comment
Collaborator
Copy Link

I've validated these changes 🥇

I've validated these changes 🥇
Robert-B reviewed 2023-01-09 17:46:18 +00:00
LED.SchDoc
Robert-B commented 2023-01-09 17:46:18 +00:00
Collaborator
Copy Link

I heard from marketing this LED should be blue.

!thumbnail[](LED.SchDoc){ diff="kyle/youtube-altium-quick-tutorial:2d630d1c3253bde24ab306d22ff06be771df0479...f7b05b8df9e0abc568fde7424d72d3acf0fe86d4" pr="1" diff-visibility="full" variant="default" view-coords="42.2,35.2,47.3,42.7" aspect-ratio="1.257" } I heard from marketing this LED should be blue.
allspice-kyle commented 2023-01-09 17:46:43 +00:00
Author
Owner
Copy Link

This is out of scope for this release - let's get to it next time.

This is out of scope for this release - let's get to it next time.
Sign in to join this conversation.
Reviewers
No Reviewers
allspice-kyle
Robert-B
Labels
Clear labels
1 - idea
Nice to have or idea to capture
2 - low
Should be resolved eventually
3 - medium
Should be resolved before product launch
4 - high
Should be resolved before next release
5 - critical
Must be fixed immediately - blocking item
bug
Something doesn't work
dfm
Design for manufacturing consideration
documentation
Improvements to supporting documentation
eol
End of life component
feature
New feature or request
firmware
Requires FW attention
layout
Requires PCB layout attention
mechanical
Requires ME attention
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Test Project
Assignees
Clear assignees
Robert-B allspice-kyle
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: allspice-kyle/BACKUP-youtube-altium-quick-tutorial#1
No description provided.
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?