AllSpice-Demos/AllSpice-epaper-demo
24
Fork 0
generated from AllSpice-Demos/AllSpice-Altium-template-repo
Files Issues 19 Design Reviews 1 Actions NEW Releases Wiki Activity

kd/remove_vendored_lib #24

Merged
allspice-kyle merged 4 commits from kd/remove_vendored_lib into develop 2023-11-03 15:36:26 +00:00
Conversation 0 Commits 4 Files Changed 5 +1 -1
allspice-kyle commented 2023-11-03 15:10:00 +00:00
Owner
Copy Link

Depends on AllSpice/AllSpice-Demo-Library#26

Depends on https://hub.allspice.io/AllSpice/AllSpice-Demo-Library/pulls/26 - Remove vendored components libary - Migrate all components to https://hub.allspice.io/AllSpice/AllSpice-Demo-Library
allspice-kyle requested review from AllSpiceAlice 2023-11-03 15:10:11 +00:00
AllSpiceAlice requested changes 2023-11-03 15:14:38 +00:00
AllSpiceAlice left a comment
Owner
Copy Link

The deleted files look good.

When you replaced the caps, it looks the net from pin 15 and 16 of the FPC connector got disconnected. Reference attached.

The deleted files look good. When you replaced the caps, it looks the net from pin 15 and 16 of the FPC connector got disconnected. Reference attached.
2.13inch_e-Paper_HAT_Schematic (2).pdf
275 KiB
epaper.SchDoc Outdated
AllSpiceAlice commented 2023-11-03 15:12:47 +00:00
Owner
Copy Link

@kyle , can you make sure you connect pins 15 and 16 on the PFC connector?

!thumbnail[](epaper.SchDoc){ diff="AllSpice/AllSpice-Demo-PCB:62535a79cd1ec74b08f9bf6cecf655d1aa42986c...484cbe5f19dfb2c7cae2b53f69b9ef861f66c22e" pr="24" diff-visibility="full" variant="default" view-coords="69.2,11.5,93.7,60.7" aspect-ratio="1.259" } @kyle , can you make sure you connect pins 15 and 16 on the PFC connector?
allspice-kyle commented 2023-11-03 15:17:32 +00:00
Author
Owner
Copy Link

Good catch 👍

Good catch 👍
allspice-kyle requested review from AllSpiceAlice 2023-11-03 15:18:09 +00:00
allspice-kyle force-pushed kd/remove_vendored_lib from 3a39555439 to 20538f0fa9 2023-11-03 15:23:53 +00:00 Compare
AllSpiceAlice approved these changes 2023-11-03 15:32:37 +00:00
AllSpiceAlice left a comment
Owner
Copy Link

Thank you for the fix

Thank you for the fix
allspice-kyle merged commit e7243a16ed into develop 2023-11-03 15:36:26 +00:00
allspice-kyle deleted branch kd/remove_vendored_lib 2023-11-03 15:36:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
AllSpiceAlice
Labels
Clear labels   
bug

Something doesn't work

  
Component

Components

  
Cost

   
dfm

Design for manufacturing consideration

  
documentation

Improvements to supporting documentation

  
eol

End of life component

  
feature

New feature or request

  
firmware

Requires FW attention

  
layout

Requires PCB layout attention

  
mechanical

Requires ME attention

  
priority/1 - idea

Nice to have or idea to capture

  
priority/2 - low

Should be resolved eventually

  
priority/3 - medium

Should be resolved before product launch

  
priority/4 - high

Should be resolved before next release

  
priority/5 - critical

Must be fixed immediately - blocking item

  
Specification
No Label
bug
Component
Cost
dfm
documentation
eol
feature
firmware
layout
mechanical
priority/1 - idea
priority/2 - low
priority/3 - medium
priority/4 - high
priority/5 - critical
Specification
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AllSpice-Demos/AllSpice-epaper-demo#24
No description provided.
Delete Branch "kd/remove_vendored_lib"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?