kd/remove_vendored_lib #24

Merged
allspice-kyle merged 4 commits from kd/remove_vendored_lib into develop 2023-11-03 15:36:26 +00:00

Depends on AllSpice/AllSpice-Demo-Library#26

Depends on https://hub.allspice.io/AllSpice/AllSpice-Demo-Library/pulls/26 - Remove vendored components libary - Migrate all components to https://hub.allspice.io/AllSpice/AllSpice-Demo-Library
allspice-kyle requested review from AllSpiceAlice 2023-11-03 15:10:11 +00:00
AllSpiceAlice requested changes 2023-11-03 15:14:38 +00:00
AllSpiceAlice left a comment
Owner

The deleted files look good.

When you replaced the caps, it looks the net from pin 15 and 16 of the FPC connector got disconnected. Reference attached.

The deleted files look good. When you replaced the caps, it looks the net from pin 15 and 16 of the FPC connector got disconnected. Reference attached.
epaper.SchDoc Outdated

@kyle , can you make sure you connect pins 15 and 16 on the PFC connector?

!thumbnail[](epaper.SchDoc){ diff="AllSpice/AllSpice-Demo-PCB:62535a79cd1ec74b08f9bf6cecf655d1aa42986c...484cbe5f19dfb2c7cae2b53f69b9ef861f66c22e" pr="24" diff-visibility="full" variant="default" view-coords="69.2,11.5,93.7,60.7" aspect-ratio="1.259" } @kyle , can you make sure you connect pins 15 and 16 on the PFC connector?
Author
Owner

Good catch 👍

Good catch 👍
allspice-kyle requested review from AllSpiceAlice 2023-11-03 15:18:09 +00:00
allspice-kyle force-pushed kd/remove_vendored_lib from 3a39555439 to 20538f0fa9 2023-11-03 15:23:53 +00:00 Compare
AllSpiceAlice approved these changes 2023-11-03 15:32:37 +00:00
AllSpiceAlice left a comment
Owner

Thank you for the fix

Thank you for the fix
allspice-kyle merged commit e7243a16ed into develop 2023-11-03 15:36:26 +00:00
allspice-kyle deleted branch kd/remove_vendored_lib 2023-11-03 15:36:36 +00:00
Sign in to join this conversation.
No description provided.